Sentry-php: HttpTransport::cleanupPendingRequests is called twice when process ends

Created on 28 Jan 2020  路  2Comments  路  Source: getsentry/sentry-php

Hello,

I juste noticed that \Sentry\Transport\HttpTransport::cleanupPendingRequests() is called when php process ends.

It is called by __destruct() method and also by a register_shutdown_function.

Is this by design or is it a bug?

Question

Most helpful comment

It's kind of a failsafe, calling it twice shouldn't have any side effect. There are some situations (see #927) where the shutdown function could be missed.

All 2 comments

It's kind of a failsafe, calling it twice shouldn't have any side effect. There are some situations (see #927) where the shutdown function could be missed.

Thanks! Closing.

Was this page helpful?
0 / 5 - 0 ratings