Sentry-php: [Monolog] Make use of Event::$logger

Created on 17 Jun 2019  路  4Comments  路  Source: getsentry/sentry-php

Hello, this is more likely question and maybe proposal to do so - why are we not using Sentry\Event::$logger and instead using it as custom extra key: $scope->setExtra('monolog.channel', $record['channel']);

Imho saving channel name to the logger instead would be better for the UX.

Confirmed Improvement

Most helpful comment

Yes, i would love to!

All 4 comments

After investigating a bit I finally found out where the logger attribute is shown in the UI of Sentry (I admit I never noticed that small text below the error message in the issues list...), so I agree with you on setting it. However, I don't have a valid point to say that we should not also set it in the extra context.

I don't have a valid point to say that we should not also set it in the extra context.

Yeah, why not 馃槈

Are you willing to open a PR addressing the issue?

Yes, i would love to!

Was this page helpful?
0 / 5 - 0 ratings

Related issues

mitchhentges picture mitchhentges  路  3Comments

tinproject picture tinproject  路  4Comments

SunflowerFuchs picture SunflowerFuchs  路  7Comments

alksily picture alksily  路  7Comments

garak picture garak  路  4Comments