Sentry-javascript: Sentry.captureException - Expected 1 arguments, but got 2.

[baloran]

• [x] Review the documentation: https://docs.sentry.io/
• [x] Search for existing issues: https://github.com/getsentry/sentry-javascript/issues
• [x] Use the latest release: https://github.com/getsentry/sentry-javascript/releases

Package + Version

• [ ] @sentry/browser
• [x] @sentry/node
• [ ] raven-js
• [ ] raven-node _(raven for node)_
• [ ] other:

Version:

4.4.2

Description

Hello,

My typescript validator throw me an error for captureException method with a problem of argument. The type expect 1 argument, the error, but do not want the second argument data.

Ex:

Sentry.captureException(new Error(msg), {
  extra: {
    ...data,
  },
})

error TS2554: Expected 1 arguments, but got 2.

Thanks

ps: I can make a _PR_ if you want.

[mogelbrod]

The second argument is only supported in raven-js/raven-node from what I can see. You'll have to do something like this in @sentry/*:

Sentry.withScope(scope => {
  scope.setTag('tagName', 'tagValue')
  scope.setExtra('extraName', 'extraValue')
  Sentry.captureException(err)
})

[HazAT]

@mogelbrod Provided the right answer, thanks :)
While we know this is more code to write we think this API is more clear and explicit.
Before the second was basically, pass an object in, "maybe" we pick it up and put in the event.

Closing this since it's not an actual bug.