Sentry-javascript: Make client injectable in requestHandler and errorHandler to make it possible to use multiple clients

[shils]

I'm currently upgrading from the "raven" module to the "@sentry/node" module in several express based Node applications. Since we report errors to multiple Sentry projects in a single application (some modules used in an application have their own projects), we instantiated clients and used the request and error middleware exposed by the client.

Is there a way to use client/hub bound middleware with the "@sentry/node" module? They seem to only be exposed by the Sentry object.

[kamilogorek]

Yes, you still can create multiple clients - https://docs.sentry.io/platforms/javascript/advance-settings/

However, linking them to specific routes is more complex. We use domains internally and read current hub based on the current execution context - https://docs.sentry.io/platforms/node/express/

You'd need to utilize our parseRequest handler which is available on Sentry.Handlers.parseRequest and make use of https://github.com/getsentry/sentry-javascript/blob/master/packages/node/src/handlers.ts#L227-L237 and https://github.com/getsentry/sentry-javascript/blob/master/packages/node/src/handlers.ts#L269-L276 code to get it stitched together.

[shils]

Thanks for the response. Are there any plans to provide the express handlers at the client/hub level?

[kamilogorek]

It'd require a lot of rewrite, but I'll leave this issue opened just in case we find some time to do this one day.

[QuotableWater7]

@shils just curious, what did you end up doing to solve this? We are late to upgrade our clients but running into the same issue.

[shils]

@QuotableWater7 We didn't go through with the upgrade server-side. I had something that seemed to work, but couldn't explain why; I still have the branch so I'll post a snippet here when I get the chance.

[skeggse]

We're still stuck on Raven 2.0.2 as a result of this :\