Sentry-javascript: Array .includes prevents this from working in IE11

[SammyM]

• [x] Review the documentation: https://docs.sentry.io/
• [x] Search for existing issues: https://github.com/getsentry/sentry-javascript/issues
• [x] Use the latest release: https://github.com/getsentry/sentry-javascript/releases

Package + Version

• [x] @sentry/browser
• [ ] @sentry/node
• [ ] raven-js
• [ ] raven-node _(raven for node)_
• [ ] other:

Version:

4.0.6

Description

There are a few instances of .includes being used in this library that's preventing it from working in IE11, for example firstFrameFunction.includes('captureMessage') in https://github.com/getsentry/sentry-javascript/blob/3ceaac916d0b7344e03d1185d4c043dba3d9fc23/packages/browser/src/parsers.ts.

I'm happy to make a pull request to fix this if that's okay?

[kamilogorek]

I'm working on getting all integration tests running on IE10/11 as we speak. Once I finish that, we'll patch all incompatibilities.

[SammyM]

Thank you!

[JustinTRoss]

Was this closed to indicate the IE11 errors are fixed? If so, do you know what version the updates are in?

[kamilogorek]

@JustinTRoss yes, everything is fixed in 4.1.0. See our changelog: https://github.com/getsentry/sentry-javascript/blob/master/CHANGELOG.md#410 :)

[browser] test: Fix all integration tests in IE10/11 and Android browsers

[JustinTRoss]

Thanks @kamilogorek . Is there a version of raven-js that includes the fix?

[kamilogorek]

@JustinTRoss raven-js always supported IE10/11, and there should be no issues there

[JustinTRoss]

Thanks. I apologize for the noise. I just realized the saucelabs compatibility chart is shared between raven-js and sentry-javascript.