Sentry-javascript: Raven interferes with ckeditor5

[jleider]

Adding raven-js to a page with ckeditor5 causes a TypeError: emitter.on is not a function error from ckeditor5 during initialization. There is a more detailed account of this same thing happening with zone.js: https://github.com/ckeditor/ckeditor5/issues/413 the issue stemmed from altering native prototypes: https://github.com/ckeditor/ckeditor5/issues/413#issuecomment-284892885

This has been reproduced with raven-js 3.15.0 and 3.19.1.

Browser: Chrome 61, Mac OS

[davidpolberger]

For what it's worth, this is affecting us too. Our interim solution is to call Raven._restoreBuiltIns(). As a result, we no longer have access to breadcrumbs in the reports, but at least CKEditor 5 works well.

[kamilogorek]

I'll look into this

[kamilogorek]

Fixed in https://github.com/getsentry/raven-js/pull/1106
@jleider @davidpolberger would love to get a confirmation that it works with your setup using updated commit in package.json

"raven-js": "getsentry/raven-js#cf89f867b0834c1e5f8c146714549db7e2078577"

[davidpolberger]

cf89f867b0834c1e5f8c146714549db7e2078577 works great, @kamilogorek, thanks! (For anyone following this thread, you need to build a package manually using npm install and grunt build.)

[kamilogorek]

Thanks @davidpolberger! I'll release new version soon.

[thedavidmeister]

i ran into this over here https://github.com/ckeditor/ckeditor5-editor-balloon/issues/12

looks like raven 3.20.1 doesn't have this error in it

[kamilogorek]

Thanks for reporting that @thedavidmeister!

[thedavidmeister]

looks like google closure advanced optimisations might be re-triggering this issue, see linked ^^