Sentry-javascript: Allow ignoreErrors to take function instead of list of regexp/strings

Created on 27 Sep 2017  Â·  5Comments  Â·  Source: getsentry/sentry-javascript

Most helpful comment

Agree that 1st option is more optimal. Please keep this comment in mind though https://github.com/getsentry/raven-js/pull/1057#issuecomment-332503372

All 5 comments

There are 2 ways we can do this.
1) Allow globalOptions.ignoreErrors to take regex/string as well as functions
2) Add something like globalOptions.shouldIgnoreError which takes a function and returns a boolean

I'd prefer the 1st option but would like to know your opinion.

Agree that 1st option is more optimal. Please keep this comment in mind though https://github.com/getsentry/raven-js/pull/1057#issuecomment-332503372

Hi,

Happy Hacktober! I will take a stab at this. PR to come in the next day or two.

Cheers!

Hey @HeroProtagonist! This issue is already in-progress – https://github.com/getsentry/raven-js/pull/1072 :)

However, we more things to choose from:

Feel free to ask if you need any help :)

@kamilogorek , Got it! I made a PR for #774 https://github.com/getsentry/raven-js/pull/1080. Hopefully it's good :crossed_fingers:

Was this page helpful?
0 / 5 - 0 ratings