Sentry-dart: Change SDK Name based on the platform

Created on 5 Oct 2020 · 11Comments · Source: getsentry/sentry-dart

enhancement

Source

marandaneto

Most helpful comment

This comment: https://github.com/getsentry/sentry-dart/pull/103#discussion_r502498630

Today what we have is a step forward but still we're not there.

sentry.dart.browser makes when Dart is compiled to JS and runs on the browser. That is not the case for Flutter Web. So for Flutter Web we would still want to have sentry.dart.flutter. On Flutter we can add a tag to identify if it's ios/android/web/windows etc. Maybe flutter.platform=....

bruno-garcia on 9 Oct 2020

👍2

All 11 comments

right now it's sentry.dart for flutter, dart and web.
ideally we'd have sentry.dart, sentry.dart.flutter, sentry.dart.browser.
right now it's controlled by https://github.com/getsentry/sentry-dart/blob/main/dart/lib/src/version.dart

marandaneto on 5 Oct 2020

on Android/Java we do it thru the build system using Gradle plugins and code generation: https://github.com/getsentry/sentry-java/blob/main/sentry/build.gradle.kts#L75-L76
let's timebox this and do at a later point if it's not easy/fast

marandaneto on 7 Oct 2020

Here we vary the client based on platform. That'll work for sentry.dart.browser, that could be set on the SentryBrowserClient class and sentry.dart on the SentryIoClient.

For Flutter we can pass the sdk.name through init when when the sentry_flutter package calls init in the sentry package.

bruno-garcia on 7 Oct 2020

👍1

cool, so we could start with this for sentry.dart.browser and sentry.dart but tackling sentry.dart.flutter in the next sprint as its focused on flutter, thanks!

marandaneto on 8 Oct 2020

🚀1

fixed in #96