Sensu-go: backend-url should not auto-append port number

Created on 30 Jan 2020  路  2Comments  路  Source: sensu/sensu-go

When I was reverse-proxying my connections through Apache, I defined my backend-url as follows:

backend-url:
  - "wss://127.0.0.1"

This resulted in the following getting created.

Jan 30 16:39:59 backend-centos-7.vagrantup.com sensu-agent[28926]: {"component":"agent","level":"info","msg":"connecting to backend URL \"wss://127.0.0.1:8081/\"","time":"2020-01-30T16:39:59Z"}

This works as I am defining the port number as part of my config file.

backend-url:
  - "wss://127.0.0.1:443"

Feature Suggestion

It should be a documented at minimum.

Possible Implementation

  • Disable appending port number
  • Create configuration to enable/disable
  • Document it

Context

As an organization, we proxy all connections through Apache/nginx so that we have a parsable access.log to perform log event parsing against. We terminated SSL at Apache, and use mod_rewrite to send websocket traffic to the right place, and do the same with /api/ and / traffic as well.

It is perceivable that in the amount of use-cases and security policies that agents will not always directly connect to the backend.

bug api documentation needs-discussion

Most helpful comment

We discussed that issue and decided it should be documented because changing the current behavior could provoke breaking changes for users that rely on this functionality.

All 2 comments

Thanks for filing this! We'll discuss whether this is a software or doc bug.

We discussed that issue and decided it should be documented because changing the current behavior could provoke breaking changes for users that rely on this functionality.

Was this page helpful?
0 / 5 - 0 ratings