Sendgrid-nodejs: Proxy Support

Created on 9 May 2017  Â·  9Comments  Â·  Source: sendgrid/sendgrid-nodejs

Issue Summary

I have gone through the documentation but couldn't find anything to enable proxy support. IS it possible to add proxy into the request ?

Technical details:

  • sendgrid-nodejs Version: master (latest commit: [commit number])
  • Node.js Version: 4.1.2
easy hacktoberfest help wanted community enhancement

All 9 comments

Hello @gupta-abhi,

It is not currently possible. I will add this to our backlog for implementation. It would need to be added here.

This issue can gain priority in our backlog by others commenting and adding reactions. The best way to move this up our queue is with a PR.

Thanks!

With Best Regards,

Elmer

@gupta-abhi @thinkingserious this is something that we would need to use as well!

Thanks for your vote @NickLiffen!

@thinkingserious Count me in. We really need it too. Speaking about possible PR — where should we start, in current implementation, if we want integrate it seamlessly?
Thanks!

Oh! It looks like now you are using request package, which means we finally have support of HTTP_PROXY & HTTPS_PROXY env. variables! Going to test it right now.

Thanks @kavu! Please let us know what you discover.

@thinkingserious isn't this already supported out of the box with request package?

const client = require('@sendgrid/client');
client.setDefaultRequest('proxy', 'https://proxy.sendgrid.com/');

@thinkingserious Totally missed to answer you. I double (triple) checked it and it works perfectly now, thanks for your transition to request.

Thanks for the follow up @kavu!

Was this page helpful?
0 / 5 - 0 ratings

Related issues

egges picture egges  Â·  3Comments

polkhovsky picture polkhovsky  Â·  3Comments

zvone187 picture zvone187  Â·  4Comments

thidasapankaja picture thidasapankaja  Â·  4Comments

agostonbonomi picture agostonbonomi  Â·  3Comments