Sendgrid-csharp: SendGrid v3 and HTML emails - Creates bad Json

[Surfrat]

I used the v2 API with no problems. I am now using the v3 API and I get a BadRequest response after sending. I investigated with Fiddler and I can see that the Json that is created for my email is bad.

See my problem here.

Thanks

Mark.

[gliljas]

The issue is in CSharpHttpClient/Client.cs which for no valid reason does this:

if (requestBody != null) { content = new StringContent(requestBody.ToString().Replace("'", "\""), Encoding.UTF8, MediaType); }

[thinkingserious]

Thanks @gliljas!

That feedback should speed the resolution of this issue.

[cosaques]

I had the same problem

[georgeemr]

same problem!!!

[thinkingserious]

Hello @gliljas, @cosaques and @georgeemr,

I believe this is fixed in v7.0.3.

[gliljas]

It solves the problem, but I strongly disagree with the solution. CSharpHttpClient still replaces single quotes with double quotes, which is has no business doing. If someone wants to use CSharpHttpClient as a generic API client, they will be surprised to find that it modifies the valid JSON.

Trust JSON.NET to do the right thing without any special escaping settings. It always produces valid JSON, such as

{"sender" : "McDonald's"}

[thinkingserious]

@gliljas,

I recall having some issues with the JSON.NET results, that is why I implemented that hack. I believe it had something to do with this: http://stackoverflow.com/a/10679340 but I'm not sure.

I know that is not the best answer and I'll leave this ticket open so we further investigate come up with a better solution.

If you have any suggestions, please let me know.

Thank you very much for your support and for taking the time to suggest improvements!

[gliljas]

I opened this issue: https://github.com/sendgrid/csharp-http-client/issues/7

...since that's where the problem is.

[thinkingserious]

@Surfrat could you also provide the raw json that is in the image above?

[thinkingserious]

Perfect, thanks!

[Surfrat]

Good news...
All my tests pass and the emails are sent successfully with ' in the html.

I will test my web app tomorrow.

[georgeemr]

@thinkingserious Everything is ok for me too. Thanks

[thinkingserious]

Fixed:

• https://github.com/sendgrid/sendgrid-csharp/releases/tag/v7.0.7
• https://www.nuget.org/packages/Sendgrid/7.0.7

Thanks to all on this thread for your continued patience!