Semanticmediawiki: 2.4.2 release

[mwjames]

Tracking issue for a possible (not yet defined) release.

• [x] #1823
• [x] #1883
• [x] #1885
• [x] #1887
• [x] #1901

Releasing

• [x] Finalize rel notes
• [x] Update version number (2.4.2)
  
  
  
  • [x] SemanticMediaWiki.php
  
  
• [x] Create tag
• [x] Create tarballs
• [x] Run composer update on smw.org
• [ ] Announce via mail
• [ ] Do a release tweet on Twitter

[mwjames]

Personally, I will have no time for this so maybe asking on the mailing-list on who wants to help out (and I'm mean NOT Karsten) otherwise I will close this task on my next week's support slot.

[JeroenDeDauw]

No need to close it next week. I'll try to get to it, but it might be afterwards.

[kghbln]

This is confusing: Apparently the code for #1901 is already within the 2.4.x branch tough it was not backported. Probably I should back off here. Basically the same for #1883: The code added to 2.5.x is partially in 2.4.x. Oh man ...

[kghbln]

@JeroenDeDauw Something we could do about release rot. As far as I see there is already enough for a 2.4.3

[JeroenDeDauw]

Things get a lot easier if the minor releases get done more frequently, ie 2.5.0 happening soon.

I don't understand your comment about 2.4.3, as there is no 2.4.2 yet

[JeroenDeDauw]

I've merged the stuff, so these commits are now on 2.4.x. Someone double checking things did not get messed up in the rebase would be good, as @mwjames mentioned already.

[JeroenDeDauw]

@SemanticMediaWiki/testers to try out the development version of 2.4.2, change the version of SMW in composer.json to 2.4.x@dev and run composer update. We want to know if the functionality critical to you is in working order.

@mwjames could you provide some pointers on what exactly to test based on what might have gotten broken?

[kghbln]

I don't understand your comment about 2.4.3, as there is no 2.4.2 yet

I meant if we had release 2.4.2 a month ago we could already have done a 2.4.3 by now.

[mwjames]

could you provide some pointers on what exactly to test based on what might have gotten broken?

Some have been tested, others relate to postgres text/bytea storage, the most critical is #1887 that should fix once and for all the registration of Property namespaces independent of whether an extension with a extension.json is invoked or not.

[kghbln]

"rebuildData.php" gives me this:

PHP Fatal error:  Class 'SMWDIHandlerWikiPage' not found in /.../extensions/SemanticMediaWiki/includes/storage/SQLStore/SMW_SQLStore3.php on line 212

Fatal error: Class 'SMWDIHandlerWikiPage' not found in /.../extensions/SemanticMediaWiki/includes/storage/SQLStore/SMW_SQLStore3.php on line 212

Note that I have killed and recreated the backend before with "setupStore.php".

[mwjames]

PHP Fatal error: Class 'SMWDIHandlerWikiPage'

Relates to a static composer autoload file. Those files exists in the 2.4.* branch. Doing a dump-autoload should correct this.

[mwjames]

This is a problem when mixing a master branch with a backport branch but nothing you can do much about it (unless you are scrapping the whole vendor dir and start from scratch).

[kghbln]

dump-autoloadfixed the issue with the class - learned something here - but now I am getting

PHP Fatal error:  Call to protected method Database::makeSelectOptions() from context 'SMW\MediaWiki\Database' in /.../extensions/SemanticMediaWiki/src/MediaWiki/Database.php on line 297

Fatal error: Call to protected method Database::makeSelectOptions() from context 'SMW\MediaWiki\Database' in /.../extensions/SemanticMediaWiki/src/MediaWiki/Database.php on line 297

[mwjames]

HP Fatal error: Call to protected method Database::makeSelectOptions() from context 'SMW\MediaWiki\Database' in /.../extensions/SemanticMediaWiki/src/MediaWiki/Database.php on line 297

This relates to [0] 1.28 and the fact that the method vanished in 1.28. I fixed this in 2.5 with #1911 by adding return DatabaseHelper::makeSelectOptions( $options ); and copied the core function to our DatabaseHelper compat class.

[0] https://phabricator.wikimedia.org/T147550

[kghbln]

This relates to [0] 1.28 and the fact that the method vanished in 1.28.

I am grumpy now.

[mwjames]

... copied the core function to our DatabaseHelper compat class.
I am grumpy now.

https://github.com/SemanticMediaWiki/SemanticMediaWiki/commit/8e0ed06aa29a511712def2c72c3d1bbf77f14531

[kghbln]

@SemanticMediaWiki/testers I have just switched the sandbox wiki to use the 2.4.x branch and have no longer encountered issues doing so. It will be very kind if you could test a couple of things on the wiki and report back in case you encounter issues. Much appreciated. Thanks for your help!

[kghbln]

another worry: Fatal error: Call to undefined method DatabaseMysqli::getSearchEngine() in /.../w/extensions/SemanticMediaWiki/src/MediaWiki/Search/Search.php on line 58 happens when trying to use "Special:Search"

[JeroenDeDauw]

That'd be caused by what https://github.com/SemanticMediaWiki/SemanticMediaWiki/pull/1897 fixes

[mwjames]

... #1897 fixes

Cherry-picked https://github.com/SemanticMediaWiki/SemanticMediaWiki/commit/76e24c6a2008cb6272dc8a3206dc8144b2188101 and added to 2.4.x.

[mwjames]

2.4.2 should now work indiscriminately with MW 1.28!

[JeroenDeDauw]

Any objections to creating the tag? I realize no release notes is not ideal, but a release without release notes is still better than no release. And for patch releases it does not matter as much as for feature releases.

[kghbln]

Cherry-picked 76e24c6 and added to 2.4.x.

Great. Thanks a lot!

2.4.2 should now work indiscriminately with MW 1.28!

At least it does with rc.0

Any objections to creating the tag? I realize no release notes is not ideal, but a release without release notes is still better than no release.

Well, it should not be too hard to pipe release notes in before tagging. I will try now. Apart form that. Except for me being grumpy all the time nobody provided feedback which can be translated into: No objection!. And this is what I think.

[mwjames]

nobody provided feedback which can be translated into

...it translates into no one bothered to actual test it which means if something goes south users are to blame for it (we gave it enough leeway).

[kghbln]

...it translates into no one bothered to actual test

I guess you misunderstood my subtle criticism. ;) Probably I am a bit more diplomatic.

[kghbln]

@JeroenDeDauw Once #2008 is merged all that is needed is to change load.php#L31 and tag

[mwjames]

I guess you misunderstood my subtle criticism. ;) Probably I am a bit more diplomatic.

I understood the subliminal message but I really have enough of this, asking people to make some simple tests and get some feedback shouldn't be that hard. Only when users encounter an issue they scream fire and like to have it fixed yesterday.

[JeroenDeDauw]

Don't worry @mwjames, @kghbln will surely protect you from the fire breathing users.

[JeroenDeDauw]

2.4.2 tag created

[kghbln]

@JeroenDeDauw Wiki fluff including wiki announcement is done. Could you do this "social" media stuff like e-mail and twitter?

[JeroenDeDauw]

Sure. Though I'm a bit dubious about classifying email as social media :)

[kghbln]

Sure.

Cool.

Though I'm a bit dubious about classifying email as social media :)

That's why I added the quotation marks to social. I totally agree that one in contrast should actually try to be serious with/in e-mails.

[mwjames]

I had a quick look at the [0] on the last 2.4.2 merge and unfortunately as well as unpleasantly, the back-port for the DatabaseHelper (required due to MW 1.28) contains a [] (PHP 5.5+) usage [1] which is invalid in a PHP 5.3/5.4* environment and ultimately fails [0].

The specific function is only called on format=debug which should barely be used by users, yet it is somewhat unsettling given that 2.4* is advertised with PHP 5.3 support.

What are the options:

1. Keep the issue until the first user complains and release a 2.4.3 by that time or
2. Push an immediate 2.4.3

[0] https://travis-ci.org/SemanticMediaWiki/SemanticMediaWiki/jobs/175415401

[1] https://github.com/SemanticMediaWiki/SemanticMediaWiki/blob/master/src/MediaWiki/DatabaseHelper.php#L25

[kghbln]

The specific function is only called on format=debug which should barely be used by users, yet it is somewhat unsettling given that 2.4* is advertised with PHP 5.3 support.

Given the extent of the impact this has it is indeed a rather marginal issue. Thus I'd go for option 1) or propose option 3) Waiting until we have another fix on top which could potentially be https://github.com/SemanticMediaWiki/SemanticMediaWiki/issues/1975 after feedback was provided.