Semantic-ui: Icon Doc page inconsistencies

[xaeroseven]

_Edit: Looks like a couple of the icon issues have been reported here too: https://github.com/Semantic-Org/Semantic-UI/issues/6175. That being said, there are still a lot of other issues I mention below_

Love the new addition of Font Awesome 5 to SUI! Very nice work! However, I was looking through the categories and noticed several inconsistencies between the Semantic UI Icons doc page and the documentation on Font Awesome's website.

• The accessible icon (the modern wheelchair icon) is missing from Accessibility, Health, Users and People, and Vehicles categories (it's in the 'Brands' section only on the SUI doc page, it would be nice to include it in these other categories)
• The youtube icon is missing from the Audio & Video section
• The Chess Rook icon is misspelled in SUI, it has chess rock, it should be chess rook
• The 'Currency' category icons have several inconsistencies, Bitcoin and others aren't listed here
• SUI has the user doctor icon instead of user md like in Font Awesome, maybe make an alias so users could use either
• The 'Payments' category icons also have several inconsistencies, amazon and apply pay are missing as well as many others

I also found several other icons that appear to be inaccurate on the docs page. I've attached images of them.

Thanks so much and let me know if I can help in any way or if you want me to submit a PR for these. Are the main SUI documentation pages something we can submit PR's for?

Best,
-Justin

These are the incorrect icons:

These are what they should look like based on the FA 5 docs:

[hammy2899]

Thanks for the feedback, the icons which aren't in the categories must have been added after I created the PR because I went through and manually added them (it was time consuming 😆 ).

The icons which are broken I have done a lot of corrections you can take a look here. The code icons are broken because the docs has its own code icon which is conflicting with them @jlukic is aware of this.

For all the other suggestions I will look into them and will try and add them to my next patch!

[xaeroseven]

😄 No worries, I bet! You did a great job though! Kudos!

Yeah, it looks like you fixed the arrows alternate horizontal, arrows alternate vertical, and the exchange alternate. It looks like the code, code branch, file code, and file code outline aren't mentioned in that new PR https://github.com/Semantic-Org/Semantic-UI/pull/6181 though.

Let me know if you have any questions on the others and thanks for the swift reply! You're crushing it @hammy2899 👍

[jlukic]

This will be out before Friday with @hammy2899’s work

[xaeroseven]

Thanks @jlukic and @hammy2899, we are using Semantic UI in both of our production web apps and have been loving it, keep up the great work!

[jlukic]

Changes got delayed, will be out next week.

[jlukic]

Getting out tonight