Semantic-ui: [Search] Search "No Results" title is not translatable
Bug: Search results "No Results" message is hardcoded:
Fix: move this message to the error array so it can be translated/overloaded.
indreksiitan
All 8 comments
Hi @indreksiitan, the templates property can easily be overriden either during the initialization, or globally with $.fn.search.settings.templates.message =.
awgv
on 14 Sep 2017
I understand that it can be, but I would still argue that it's bad to hardcode translations, especially if there is a general logic for handling those in place.
indreksiitan
on 14 Sep 2017
@indreksiitan We鈥檒l take a look.
awgv
on 14 Sep 2017
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 30 days if no further activity occurs. Thank you for your contributions.
![stale[bot] picture](https://avatars.githubusercontent.com/in/1724?v=4&s=40)
stale[bot]
on 23 Feb 2018
This still needs a fix.
indreksiitan
on 23 Feb 2018
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 30 days if no further activity occurs. Thank you for your contributions.
stale[bot]
on 24 May 2018
Why is this hardcoded?
brunohkbx
on 3 Oct 2018
Implemented since https://github.com/fomantic/Fomantic-UI 2.4.2
lubber-de
on 19 Feb 2019
Related issues
zhaoyao91
路
3Comments
ghost
路
3Comments
mixerp
路
3Comments
kntmrkm
路
3Comments
larsbo
路
3Comments
Most helpful comment
I understand that it can be, but I would still argue that it's bad to hardcode translations, especially if there is a general logic for handling those in place.