Semantic-ui: [Modal] callback method onHide() returns false but Dimmer is hidden

Created on 23 Aug 2016  路  4Comments  路  Source: Semantic-Org/Semantic-UI

If we add the callback method onHide to a modal, the dialog should not be closed if false is returned which works but the dimmer is hidden.

Confirmed Bug stale

Most helpful comment

I can also confirm this behaviour: Closing the modal by pressing the Esc key works fine, but clicking on the dimmer ignores the results of onHide(). In fact, it appears that the dialog is hidden BEFORE anything else happens. The state is properly tracked (if onHide() returns false the dialog thinks it's still visible) BUT the actual display no longer contains a visible dialog.

All 4 comments

I can also confirm this behaviour: Closing the modal by pressing the Esc key works fine, but clicking on the dimmer ignores the results of onHide(). In fact, it appears that the dialog is hidden BEFORE anything else happens. The state is properly tracked (if onHide() returns false the dialog thinks it's still visible) BUT the actual display no longer contains a visible dialog.

I have a fiddle that exhibits this wrong behavior, simply click on the dimmer and watch the modal disappear!

There has been no activity in this thread for 90 days. While we care about every issue and we鈥檇 love to see this fixed, the core team鈥檚 time is limited so we have to focus our attention on the issues that are most pressing. Therefore, we will likely not be able to get to this one.

However, PRs for this issue will of course be accepted and welcome!

If there is no more activity in the next 90 days, this issue will be closed automatically for housekeeping. To prevent this, simply leave a reply here. Thanks!

Fixed since Fomantic-UI 2.7.0 by https://github.com/fomantic/Fomantic-UI/pull/288
See adjusted jsfiddle by @karvanit using FUI here http://jsfiddle.net/q8c5zn3m/

Was this page helpful?
0 / 5 - 0 ratings

Related issues

Morrolan picture Morrolan  路  3Comments

mllamazares picture mllamazares  路  3Comments

ghost picture ghost  路  3Comments

guilhermeblanco picture guilhermeblanco  路  3Comments

sarbona picture sarbona  路  3Comments