Semantic-ui-react: Form field has aria-invalid attribute when error is false

[aoelen]

Bug Report

Steps

Use a form field, for example:
<Form.Field id='form-input-control-error-email' control={Input} label='Email' placeholder='[email protected]' error={false} />

Expected Result

The aria-invalid attribute should not be present (or should be false)

Actual Result

The aria-invalid attribute is set to true:

<input aria-describedby="form-input-control-error-email-error-message" aria-invalid="true" placeholder="[email protected]" id="form-input-control-error-email" type="text">

Version

1.2.0

[layershifter]

Thanks for reporting. It seems that condition there should be simpler 🐱

src/collections/Form/FormField.js

    'aria-describedby': ariaDescribedBy,
-   'aria-invalid': error !== undefined ? true : undefined,
+   'aria-invalid': error ? true : undefined,

Would you like to submit a PR?

[aoelen]

Done, I added some tests as well

[layershifter]

A fix was released in [email protected] 🎉