Semantic-ui-react: Dropdown: `search` prop has invalid typings

[charliematters]

Bug Report

Steps

Use a dropdown with a default search prop

Expected Result

That it uses the default search function

Actual Result

Type 'true | ((options: DropdownItemProps[], value: string) => boolean | DropdownItemProps[])' is not assignable to type '(options: DropdownItemProps[], value: string) => boolean | DropdownItemProps[]'.
  Type 'true' is not assignable to type '(options: DropdownItemProps[], value: string) => boolean | DropdownItemProps[]'.ts(2322)

Version

1.1.0

Testcase

Before:

search?: boolean | ((options: DropdownItemProps[], value: string) => DropdownItemProps[])

After:

search?: (options: DropdownItemProps[], value: string) => DropdownItemProps[] | boolean

The new type means that you can provide a function, but that function has to return an array of options, or a boolean. Previously, you could provide a boolean (e.g. <Dropdown search />) or alternatively a function

[layershifter]

@charliematters great report 👍 Would you like to create a PR to fix it?

[charliematters]

I will have a go after work!

[charliematters]

I raised the PR but it failed at the first hurdle because I forgot to add a label, ad now I can't update it 🤦‍♂️

Anyway, it's there - let me know if it needs updating

[layershifter]

I raised the PR but it failed at the first hurdle because I forgot to add a label, ad now I can't update it 🤦‍♂️

@charliematters no worries, only maintainers can manage labels as we are using them to generate changelogs.