Semantic-ui-react: React deprecation warning for Menu component

Created on 22 Aug 2019  路  9Comments  路  Source: Semantic-Org/Semantic-UI-React

Bug Report

Steps

Use <Menu> component

Expected Result

No warning in JS console

Actual Result

Following warning message in JS console:

Warning: componentWillReceiveProps has been renamed, and is not recommended for use. See https://fb.me/react-async-component-lifecycle-hooks for details.

* Move data fetching code or side effects to componentDidUpdate.
* If you're updating state whenever props change, refactor your code to use memoization techniques or move it to static getDerivedStateFromProps. Learn more at: https://fb.me/react-derived-state
* Rename componentWillReceiveProps to UNSAFE_componentWillReceiveProps to suppress this warning in non-strict mode. In React 17.x, only the UNSAFE_ name will work. To rename all deprecated lifecycles to their new names, you can run `npx react-codemod rename-unsafe-lifecycles` in your project source folder.

Please update the following components: Menu

Version

0.87.3

triage

Most helpful comment

Have this warning too now at "semantic-ui-react": "^0.88.2"

All 9 comments

馃憢 Thanks for opening your first issue here! If you're reporting a 馃悶 bug, please make sure you've completed all the fields in the issue template so we can best help.

We get a lot of issues on this repo, so please be patient and we will get back to you as soon as we can.

There are a lot more deprecated lifecycles in React 16.9 that Semantic UI React still use.

Just got

react-dom.development.js:12029 Warning: componentWillMount has been renamed, and is not recommended for use. See https://fb.me/react-async-component-lifecycle-hooks for details.

* Move code with side effects to componentDidMount, and set initial state in the constructor.
* Rename componentWillMount to UNSAFE_componentWillMount to suppress this warning in non-strict mode. In React 17.x, only the UNSAFE_ name will work. To rename all deprecated lifecycles to their new names, you can run `npx react-codemod rename-unsafe-lifecycles` in your project source folder.

Please update the following components: Dropdown

Same issue for Portal and others.

Also got annoying warnings for CardElement, Checkbox, Menu, Provider, Tab

Hey Guys,

What is the work around for these warnings?

Fix was released in 0.88.0 few hours ago.

Also got annoying warnings for CardElement, Checkbox, Menu, Provider, Tab

CardElement, Provider are not our components.

Have this warning too now at "semantic-ui-react": "^0.88.2"

"semantic-ui-react": "^0.88.2" has this warning with Menu , Button
Warning: Using UNSAFE_componentWillReceiveProps in strict mode is not recommended and may indicate bugs in your code. See https://fb.me/react-unsafe-component-lifecycles for details.

  • Move data fetching code or side effects to componentDidUpdate.
  • If you're updating state whenever props change, refactor your code to use memoization techniques or move it to static getDerivedStateFromProps. Learn more at: https://fb.me/react-derived-state

Please update the following components: Menu

index.js:1 Warning: findDOMNode is deprecated in StrictMode. findDOMNode was passed an instance of RefFindNode which is inside StrictMode. Instead, add a ref directly to the element you want to reference. Learn more about using refs safely here: https://fb.me/react-strict-mode-find-node
in button (created by Button)
in RefFindNode (created by Ref)
in Ref (created by Button)
in Button (at NavBar.tsx:17)
in div (created by MenuItem)
in MenuItem (at NavBar.tsx:16)
in div (created by Container)
in Container (at NavBar.tsx:10)
in div (created by Menu)
in Menu (at NavBar.tsx:9)
in NavBar (at App.tsx:35)
in div (at App.tsx:34)
in App (at src/index.tsx:9)
in StrictMode (at src/index.tsx:8)

Looks like it is still an issue or a new issue came up in "semantic-ui-react": "^0.88.2". can you open this back up?

Was this page helpful?
0 / 5 - 0 ratings

Related issues

GautierT picture GautierT  路  3Comments

hankthewhale picture hankthewhale  路  3Comments

KevinGorjan picture KevinGorjan  路  3Comments

jayphelps picture jayphelps  路  3Comments

nix1 picture nix1  路  3Comments