Semantic-ui-react: Modal: not centered in IE11

Created on 17 Jan 2019  路  7Comments  路  Source: Semantic-Org/Semantic-UI-React

The modal component opens down and to the right on IE. It is centered on firefox and chrome. Additionally I can't open https://react.semantic-ui.com/modules/modal/ in IE to see if the issue is present on your website. I have not yet found a css workaround for this and I am not sure why this issue is only present in IE. Any help would be greatly appreciated.

bug

Most helpful comment

Update: I added style={{ position: 'static' }} to the modal component and it resolved this issue.

All 7 comments

馃憢 Thanks for opening your first issue here! If you're reporting a 馃悶 bug, please make sure you've completed all the fields in the issue template so we can best help.

We get a lot of issues on this repo, so please be patient and we will get back to you as soon as we can.

Tested in IE 18 - 15 on Windows 10 and this is working. Which version of IE is this not working for?

Hi, Thankyou for getting back to me so quickly!
The modal component is not centered on IE 11.0.9600.18816 on Windows 7. I also can't access any of the documentation on IE except for the initial Introduction page. All of the links in the left hand menu render a blank page. If I open the console on the intro page (https://react.semantic-ui.com/) I get a console error: SCRIPT438: Object doesn't support property or method 'assign'
image
If I click on any of the items in the sidebar, I get a Babel error in the console
image

Update: I added style={{ position: 'static' }} to the modal component and it resolved this issue.

I have the same issue on the modal page: https://react.semantic-ui.com/modules/modal/. This page has errors and shows nothing.
annotation 2019-01-21 173230

UPD: It is related, I have seen this late. https://github.com/Semantic-Org/Semantic-UI-React/issues/3369

I can confirm that this is an issue in IE 11.0.105:
screen shot 2019-02-13 at 1 58 39 pm
Oddly, it's not an issue for the non-React package:
screen shot 2019-02-13 at 1 59 02 pm
As mentioned by @MariaBamundo, setting position: static fixes this. The parent dimmer aligns its children in the center, so we don't need position: absolute. Some initial cross-browser testing suggests that setting position: static doesn't break things in any browser. So it may make sense to just take out position: absolute from .ui.modal. This should probably be done in the semantic-ui package. I'll open an issue there.

I provided a fix in #3679, please try it, feedback there is much appreciated 馃檶

Was this page helpful?
0 / 5 - 0 ratings

Related issues

dilizarov picture dilizarov  路  3Comments

ryanpcmcquen picture ryanpcmcquen  路  3Comments

mattmacpherson picture mattmacpherson  路  3Comments

hankthewhale picture hankthewhale  路  3Comments

laukaichung picture laukaichung  路  3Comments