Semantic-ui-react: Modal: size="fullscreen" sticks to left

[argoyb]

Bug Report

Steps

1. Go to https://react.semantic-ui.com/modules/modal/#variations-size
2. Click on "Fullscreen"

Expected Result

Expected popup to be centered

Actual Result

Popup sticks to left border

Version

v0.84.0

Testcase

Please see https://react.semantic-ui.com/modules/modal/#variations-size

[welcome[bot]]

👋 Thanks for opening your first issue here! If you're reporting a 🐞 bug, please make sure you've completed all the fields in the issue template so we can best help.

We get a lot of issues on this repo, so please be patient and we will get back to you as soon as we can.

[argoyb]

WebInspector shows left: 0!important; property for .ui.fullscreen.modal which seems to cause the issue

[layershifter]

https://github.com/Semantic-Org/Semantic-UI-React/issues/3289#issuecomment-440224606

We should temporary switch our docs to semantic-ui package.

[shamin]

@layershifter I think this one is fixed in https://github.com/Semantic-Org/Semantic-UI/commit/36d5857eaba7e6a51ca522521f8505f5c343405c

[KunleMichaels]

has this issue been fixed? i'm new to open source and i will like to take this as my first issue

[layershifter]

To clarify the issue:

• this bug was fixed in Semantic UI 2.4.1, https://github.com/Semantic-Org/Semantic-UI/commit/36d5857eaba7e6a51ca522521f8505f5c343405c
• [email protected] and [email protected] aren't published to NPM, https://github.com/Semantic-Org/Semantic-UI/issues/6646
• [email protected] and [email protected] has wrong prebuilt CSS and it points to 2.4.0 which contains this bug 😭

I made a PR (#3367) that will fix this issue for our doc site. For users: please ensure that you're really using SUI 2.4.2.

[zigacernigoj]

Just a reminder. The issue is still present in semantic-ui-react 0.86.0, because it uses semantic-ui-css 2.4.1
Thought it was fixed as the issue is closed and PR merged.