Semantic-ui-react: Modal: closing on clicking inside itself after height change

Created on 7 Jun 2018  路  5Comments  路  Source: Semantic-Org/Semantic-UI-React

Bug Report

After adding more input fields in modal, clicking on plain link causes modal close. Seems like the height is changed and initial calculation of modal rectangle became outdated, so it behaves like on clicking outside of the modal.
Of course, closeOnDimmerClick={false} prop prevents this strange behavior.

Steps

  1. go to test case sandbox
  2. open modal by clicking Login (top left corner, also zoom out to see the links of modal)
  3. click Register link of the modal (the form just got bigger and Login click is out of initial dimension of the modal)
  4. click Login link of the modal

Expected Result

Modal is open

Actual Result

Modal is closed

Version

Semantic-UI React 0.81.1

Testcase

https://codesandbox.io/s/30n2v379r1 Semantic-UI CSS 2.2.13
upd. https://codesandbox.io/s/n70787j0yp Semantic-UI CSS 2.3.1

bug

Most helpful comment

I've updated testcase to use SUI 2.3. However, I think that the problem is caused by removal of a click's target node.

All 5 comments

I've updated testcase to use SUI 2.3. However, I think that the problem is caused by removal of a click's target node.

There has been no activity in this thread for 180 days. While we care about every issue and we鈥檇 love to see this fixed, the core team鈥檚 time is limited so we have to focus our attention on the issues that are most pressing. Therefore, we will likely not be able to get to this one.

However, PRs for this issue will of course be accepted and welcome!

If there is no more activity in the next 180 days, this issue will be closed automatically for housekeeping. To prevent this, simply leave a reply here. Thanks!

Didn't work with SUIR for a while. Not sure if it's still reproducible. Will take a look...

There has been no activity in this thread for 180 days. While we care about every issue and we鈥檇 love to see this fixed, the core team鈥檚 time is limited so we have to focus our attention on the issues that are most pressing. Therefore, we will likely not be able to get to this one.

However, PRs for this issue will of course be accepted and welcome!

If there is no more activity in the next 180 days, this issue will be closed automatically for housekeeping. To prevent this, simply leave a reply here. Thanks!

This issue will be closed due to lack of activity for 12 months. If you鈥檇 like this to be reopened, just leave a comment; we do monitor them!

Was this page helpful?
0 / 5 - 0 ratings