Semantic-ui-react: Modal: Scrolling doesn't work properly after reopen

Created on 2 Oct 2017  路  1Comment  路  Source: Semantic-Org/Semantic-UI-React

Steps

  1. Open scroll modal
  2. Scroll modal
  3. Close scroll modal
  4. Open scroll modal again
  5. Scroll modal

    Expected Result

Modal must be scrollable

Actual Result

Modal no longer scrollable

Version

0.74.2

Testcase

https://react.semantic-ui.com/modules/modal

bug

Most helpful comment

There are no need to scroll this modal. In fact, error comes from this condition. After modal will be closed it should reset scrolling state as I think:

  handleClose = (e) => {
    debug('close()')

    const { onClose } = this.props
    if (onClose) onClose(e, this.props)

-    this.trySetState({ open: false })
+    this.trySetState({ open: false }, { scrolling: undefined })
  }

>All comments

There are no need to scroll this modal. In fact, error comes from this condition. After modal will be closed it should reset scrolling state as I think:

  handleClose = (e) => {
    debug('close()')

    const { onClose } = this.props
    if (onClose) onClose(e, this.props)

-    this.trySetState({ open: false })
+    this.trySetState({ open: false }, { scrolling: undefined })
  }
Was this page helpful?
0 / 5 - 0 ratings

Related issues

levithomason picture levithomason  路  47Comments

layershifter picture layershifter  路  32Comments

skleeschulte picture skleeschulte  路  22Comments

the-simian picture the-simian  路  24Comments

coolpopo picture coolpopo  路  26Comments