Semantic-ui-react: Bug(Popup): Clicking on another Popup's trigger doesn't close open Popups.

Created on 30 Jan 2017  路  6Comments  路  Source: Semantic-Org/Semantic-UI-React

Steps

  1. Open an on="click" popup
  2. Click on another trigger for a different on="click" popup while the first is still open

    Expected Result

The first Popup should close and the second should open

Actual Result

Both Popups stay open.

Version

0.64.4

Testcase

Here's an example:
http://codepen.io/anon/pen/XpVqKq

It happens on the doc page as well:

screen shot 2017-01-30 at 9 53 14 am

bug good first issue help wanted

Most helpful comment

Released in [email protected].

All 6 comments

Yep, the trigger click handler is stopping propagation. We should instead be checking if the click was inside the trigger node, rather than stopping the event from propagating.

https://github.com/Semantic-Org/Semantic-UI-React/blob/master/src/addons/Portal/Portal.js#L249

PR coming.

Released in [email protected].

The issue seems to be back:
image

Any update on this issue? I'm having exactly the same experience as described above.

Please don't post anything in the old closed issues. If you have an issue, please fill a new issue with issue template.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

ryanpcmcquen picture ryanpcmcquen  路  3Comments

eXtreme picture eXtreme  路  3Comments

SajagTiwari picture SajagTiwari  路  3Comments

mattmacpherson picture mattmacpherson  路  3Comments

eGust picture eGust  路  3Comments