Semantic-ui-react: Popup - allow mouseEnter, mouseLeave delay to be set via props

[bw2]

Currently mouseEnter and mouseLeave delay values are hard-coded.
https://github.com/Semantic-Org/Semantic-UI-React/blob/master/src/modules/Popup/Popup.js#L264

It would be great if these could be set via popup props.

[levithomason]

This is actually a bug. All portal props (i.e. mouseEnterDelay, etc.) can be added to a Popup and it _should_ pass them through to the underlying Portal:

https://github.com/Semantic-Org/Semantic-UI-React/blob/master/src/modules/Popup/Popup.js#L346

However, when I try this in the doc site editor, I cannot get it to work. It seems the value is always overridden somehow.

Fix

Currently, there is no visibility of this in the docs nor typings. We should instead explicitly add all the portal props to the Popup's propTypes and typings. Doing this will also change how the props are built-up and consumed. This may in fact also resolve the bug.

[tarang9211]

@levithomason this still open? i'd like to help out if so, with more info and knowledge of how to reproduce it!

[levithomason]

I, unfortunately, don't have the bandwidth for a walkthrough, however, you can check out #1169 for more info on what needs to happen here. I will be glad to offer PR review comments regarding what is missing or needs done, I just can't promise that I'll be able to also help craft the solutions.

[kasbah]

This seems to be fixed in 0.66.0 but it's not documented. Works for me with mouseLeaveDelay and mouseEnterDelay props.

[levithomason]

I've revamped a lot of Portal and Popup logic. Confirming it was fixed in the latest release.

Closing this issue as we have #1169 for documenting missing props and behaviors.

[nfantone]

@levithomason I tried this today and, while it seems to work (behaves like your GIF above), the Popup is still triggered by a _click_ event, even if setting on="hover".

(Note that mouseEnterDelay is set to 10s).

---

EDIT: Created #2583.