Seed: Question: App::update vs seed::update

Created on 20 Jun 2019 · 7Comments · Source: seed-rs/seed

As far as I can see there are two ways to trigger an update event:

via the update method of an App instance without (De)Serialization
via the global seed::update function with (De)Serialization

I wonder what's exactly the difference and which way do you recommend?
Consider this context:

let app = seed::App::build(Model::default(), update, view::app)
        .finish()
        .run();
    let a = app.clone();
    let on_message = Closure::wrap(Box::new(move |ev: MessageEvent| {
        let txt = ev.data().as_string().unwrap();
        let notification: NotificationPayload = serde_json::from_str(&txt).unwrap();
        a.update(Msg::ServerMsg(notification));
    }) as Box<FnMut(MessageEvent)>);

I could get rid of app.clone() and use seed::update instead:

```diff

let a = app.clone();
let on_message = Closure::wrap(Box::new(move |ev: MessageEvent| {
let txt = ev.data().as_string().unwrap();
let notification: NotificationPayload = serde_json::from_str(&txt).unwrap();
a.update(Msg::ServerMsg(notification));
seed::update(Msg::ServerMsg(notification));
}) as Box ```

What do you think? Is the clone operation faster than serializing and deserializing the message + triggering an extra browser event?
Or what other aspects do I have to take into account?

question

Source

flosse

All 7 comments

I would use seed::update where using app is problematic - e.g. https://github.com/David-OConnor/seed/blob/master/examples/animation_frame/src/lib.rs#L81 => we don't have access to App instance here.

And app.update for other cases - I think that clone should be cheap, because all App's fields are Rc (https://github.com/David-OConnor/seed/blob/master/src/vdom.rs#L200).