Security-wg: Standarize the format of vulnerabilities on core and npm databases

[dgonzalez]

There are few discrepancies in core and npm databases:

• https://github.com/nodejs/security-wg/tree/master/vuln/core
• https://github.com/nodejs/security-wg/tree/master/vuln/npm

For example dates are inconsistent across different files. We should document the format and add CI to validate PRs. @vdeturckheim I think you did some work on this with Joi validators.

[dgonzalez]

Here is the Joi schema: https://github.com/nodejs/security-wg/pull/102/files#diff-5b7a60d6cbe47068f950c8112a7c2a54R22

[vdeturckheim]

What format do you believe we should keep for dates @dgonzalez ? The Joi validation has been retro-engineered from what we had, but maybe it is time we make the change we want to the format before the db gets too big.

[dgonzalez]

I am ok with the dd-mm-yyyy or similar. Hour does not bring too much value.

On 28 March 2018 at 13:53, Vladimir de Turckheim [e-mail]
wrote:

What format do you believe we should keep for dates @dgonzalez
https://github.com/dgonzalez ? The Joi validation has been
retro-engineered from what we had, but maybe it is time we make the change
we want to the format before the db gets too big.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/nodejs/security-wg/issues/171#issuecomment-376875481,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAHkOshLIYETHIomAF2_5oCOqFDDWtTyks5ti4ezgaJpZM4S3pAT
.

[ChALkeR]

dd-mm-yyyy

yyyy-mm-dd? That's what we now have for part of the reports, also that doesn't get mixed up in US vs the rest of the world. Also, sortable ;-).

[vdeturckheim]

I'm usually pro yyyy-mm-dd ^^

[dgonzalez]

Works for me.

On 28 March 2018 at 13:56, Vladimir de Turckheim [e-mail]
wrote:

I'm usually pro yyyy-mm-dd ^^

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/nodejs/security-wg/issues/171#issuecomment-376876600,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAHkOn689bEdDbloPfi_mdUD3UNIc7auks5ti4iNgaJpZM4S3pAT
.

[lirantal]

yep

[lirantal]

sorry, accidentally hit the wrong button

[sam-github]

can this be closed now that #216 has landed?

[lirantal]

Yes this is done.