Securedrop: Reloading URL to deleted source causes internal server error

[eloquence]

Encountered during client QA. Tested deleting a source in the client, then reloaded messages/submission view for that same source in the Journalist Interface.

Expected result

A helpful message telling me that the source could not be found.

Observed result

Internal server error displayed in Journalist Interface

[prateekj117]

@eloquence By client, do you mean securedrop-client, because that would mean the issue is in API.

Also, I couldn't reproduce issue #4618, which might be the same as this if this is for Web Interface.

[zenmonkeykstop]

@prateekj117 This should just return a 404 in the JI currently, having it give a more specific error ("unknown source, it may have been deleted by another user" or similar) would be an improvement.

[prateekj117]

@zenmonkeykstop Sure. Will do that.

[prateekj117]

@zenmonkeykstop Ok, so it doesn't do a soft-deletion in Sources Table, so instead of 404, should we return this in every case?