Sdwebimage: Xcode 12 SPM `IPHONEOS_DEPLOYMENT_TARGET` warning

[diogot]

New Issue Checklist

• [X] I have read and understood the CONTRIBUTING guide
• [X] I have read the Documentation
• [X] I have searched for a similar issue in the project and found none

Issue Info

Info | Value |
-------------------------|-------------------------------------|
Platform Name | ios
Platform Version | 14
SDWebImage Version | 5.9.1
Integration Method | SPM
Xcode Version | Xcode 12
Repro rate | all the time (100%)

Issue Description and Steps

Using SDWebImage in SPM on Xcode 12 GM produces this warning:

The iOS Simulator deployment target 'IPHONEOS_DEPLOYMENT_TARGET' is set to 8.0, but the range of supported deployment target versions is 9.0 to 14.0.99.

According to this thread the problem is that this line is overriding Xcode settings forcing IPHONEOS_DEPLOYMENT_TARGET to an unsupported SDK version by Xcode 12.

The solution on the thread was remove the platforms section, because they support all platforms/versions this might be also applicable here.

[dreampiggy]

Designed behavior. SDWebImage 5.x version still need to support iOS 8+.

If we remove that platform limit, this will cause error, not warning. Because if one Sub-dependency, for example, SDWebImageWebPCoder. Use another iOS 8+ platform, that will cause an dependency check fail (low deployment target should not dependent high deployment target). This is an recursive issue.

See more: https://github.com/SDWebImage/SDWebImageWebPCoder/pull/43

For iOS 9+ min deployment target version, we will schedule to release SDWebImage 6.0.

[diogot]

Thanks!

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If this is still an issue, please make sure it is up to date and if so, add a comment that this is still an issue to keep it open. Thank you for your contributions.

[diogot]

This issue will be addressed in version 6, so I think it shouldn't be closed by stale bot yet.