Sdk: [CP] Cherry-pick for AOT compiler assertion preventing certain apps from compiling

Created on 17 Oct 2020  路  4Comments  路  Source: dart-lang/sdk

commit(s) to merge: 13d2937f768180b083ce6ffdcf7d3cd9a4c5440a

merge instructions: clean (auto)merge

What is the issue: Compiling AOT applications that have classes with many fields where our whole-world analysis tells us that the 65+th field can be unboxed and an implicit getter function is needed, will hit a too conservative release assertion, thereby not allowing compiling those applications. The assertion assumes we never have unboxed return values of implicit getter functions if the field itself is boxed - though this can happen if the field is outside a 64-bitmap (in which case we box the field).

What is the fix: Removing the release assertion and allowing boxed-field+unboxed-return situation.

Why cherrypick: Allows AOT compiling applications that wouldn't compile otherwise.

Risk: Low.

Link to original issue(s):

/cc @kevmoo @mit-mit @whesse @athomas @vsmenon @franklinyow

area-vm cherry-pick-review cp-approved merge-to-beta merge-to-stable

Most helpful comment

Merged to stable for 2.10.3 (ecf9ce8ef42de11033801b2870e8b310c3722902).

All 4 comments

@pcsosinski

Approved

Merged to beta in bba1aeca3a6062bbedb0147a39c093a9ff7291b2 (2.11.0-213.4.beta). The issue will be left open until merged to stable (there is no separate tracking issue for the merge-to-beta).

Merged to stable for 2.10.3 (ecf9ce8ef42de11033801b2870e8b310c3722902).

Was this page helpful?
0 / 5 - 0 ratings

Related issues

ranquild picture ranquild  路  3Comments

nex3 picture nex3  路  3Comments

gspencergoog picture gspencergoog  路  3Comments

Hixie picture Hixie  路  3Comments

55555Mohit55555 picture 55555Mohit55555  路  3Comments