Sdk: [CP][stable channel][beta channel] Fix handling of named parameter types in CFE when initialising from Kernel

Created on 15 Oct 2020  路  9Comments  路  Source: dart-lang/sdk

commit(s) to merge: aa329dc0d05b398ce57057a0d2842b7167130845

merge instructions: clean merge

What is the issue: When initialising from Kernel binary CFE incorrectly handles types of named parameters when handling function types, leading it to use types of positional parameters at corresponding positions instead.

What is the fix: Fix the typo in the code to make it refer to the named parameters.

Why cherrypick: Fundamental bug, has potential to impact large number of users.

Risk: Low, the fix is 1 line correction of a typo.

Link to original issue(s): https://github.com/flutter/flutter/issues/65324, https://github.com/flutter/flutter/issues/68092

/cc @dgrove @kevmoo @mit-mit @whesse @athomas @vsmenon @franklinyow @johnniwinther

area-front-end cherry-pick-review cp-approved merge-to-beta merge-to-stable
Source
picture mraleph
🎉1

All 9 comments

FYI @pcsosinski

franklinyow picture franklinyow on 15 Oct 2020

Approved in SCRUM

franklinyow picture franklinyow on 15 Oct 2020
🎉1

Merged to beta in bba1aeca3a6062bbedb0147a39c093a9ff7291b2 (2.11.0-213.4.beta). The issue will be left open until merged to stable (there is no separate tracking issue for the merge-to-beta).

athomas picture athomas on 22 Oct 2020
🎉1

Cool! So this is just the Dart side, right? It is still not shipped in any flutter channel yet or am I missing something (I just tried to verify if the fix works but it is still failing with the current flutter dev channe using Flutter 1.23.xl).

llucax picture llucax on 22 Oct 2020

Yes, it means Flutter could now cherry-pick that hash to Flutter. It will appear on Dart's standalone release channels tomorrow morning.

@pcsosinski I'm not sure how to answer the if/when this will reach Flutter users question.

athomas picture athomas on 22 Oct 2020
👍1

Merged to stable for 2.10.3 (ecf9ce8ef42de11033801b2870e8b310c3722902).

athomas picture athomas on 27 Oct 2020
🎉1

This is fixed now in the stable (using dart 2.10.3) and dev (using dart 2.11.0 build 2.11.0-260.0.dev) channels.

The beta channel (using dart 2.11.0 build 2.11.0-213.1.beta) seems to be still broken though, not sure if that's an overlook or if it takes more time for changes in 2.11 to land there...

Thanks!

llucax picture llucax on 2 Nov 2020

And I can confirm this also fixes https://github.com/flutter/flutter/issues/65324.

llucax picture llucax on 2 Nov 2020

Re: Flutter beta: It's released in Dart 2.11.0-213.4.beta, Dart 2.11.0-213.1.beta does not have the fix.

athomas picture athomas on 2 Nov 2020
Was this page helpful?
0 / 5 - 0 ratings

Related issues

Hixie picture Hixie  路  3Comments
nex3 picture nex3  路  3Comments
gspencergoog picture gspencergoog  路  3Comments
rinick picture rinick  路  3Comments
xster picture xster  路  3Comments