Sdk: [Analysis Server] Dart type suggestion not work correctly since 1.22 !! (Benchmark proof 1.17, 1.20, 1.22)

Created on 2 Oct 2020 · 7Comments · Source: dart-lang/sdk

Hi,

Flutter Dart type suggestion work bad 1.22 on intelij IDEA, suggestions are not relevant. We pass to many times to write all word instead of using suggestions system :/

I make two tests around with function call and type suggestions. I tested under theses versions of Flutter :

1.22.0
1.20.4
1.17.0

Result : 1.17 have better suggestions...

On flutter 1.22.0 :

Try to got print() function suggestion :
_One letter :_

_Full word:_

Try to got CrossAxisAlignment suggestions :
_Empty :_

_3 letters :_

On fluttter 1.20.4:

Try to got print() function suggestion :
_One letter :_

_Full word:_

Try to got CrossAxisAlignment suggestions :
_Empty :_

_3 letters :_

On flutter 1.17.0 :

Try to got print() function suggestion :
_One letter :_

_Full word:_

Try to got CrossAxisAlignment suggestions :
_Empty :_

_3 letters :_

As you can see on these images, suggestions weren't based on type... I lose too much time...

analyzer-server area-analyzer

Source

EArminjon

👍3

Most helpful comment

Same here :/
Even worse, the temporary solution from https://github.com/dart-lang/sdk/issues/38739#issuecomment-541432145 didn't work now

debuggerx01 on 12 Oct 2020

👍3 👀1

All 7 comments

I hope provided enough data about the problem.

Here my flutter doctor -v without flutter version (because changed for every test)

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.0)
    • Android SDK at /home/student/Android/Sdk
    • Platform android-30, build-tools 30.0.0
    • Java binary at: /snap/android-studio/91/android-studio/jre/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6222593)
    • All Android licenses accepted.

[✓] Android Studio (version 4.0)
    • Android Studio at /snap/android-studio/91/android-studio
    • Flutter plugin version 48.1.2
    • Dart plugin version 193.7547
    • Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6222593)

[✓] Connected device (1 available)
    • Android SDK built for x86 (mobile) • emulator-5554 • android-x86 • Android 10 (API 29) (emulator)

EArminjon on 2 Oct 2020

Can you provide information about where you're requesting code completion, what you expected to see, and what you mean by "not work correctly"?

bwilkerson on 2 Oct 2020

For "print" example :

You can see that the suggestion which have the same length are not at first position… Why a larger word got the first position Instead of the one which match exactly ?

For the "crossAxisAlignement" :

Instead of display first all matching type suggestion (CrossAxisAlignment.center, CrossAxisAlignment.end, CrossAxisAlignment.start...), we got some boolean value, some context and for 1.20 a spam from cupertino... How can that be possible ?

They're is no precise location, because it's a general problem: it appear for every suggestion case…

EArminjon on 2 Oct 2020

Same here :/
Even worse, the temporary solution from https://github.com/dart-lang/sdk/issues/38739#issuecomment-541432145 didn't work now

debuggerx01 on 12 Oct 2020

👍3 👀1

Same problem here, after upgrading to 1.22.1 autocomplete doesn't work anymore on VS Code even with "Auto Import Completions" turned off... it's really frustrating...

[flutter] flutter doctor -v
[√] Flutter (Channel stable, 1.22.1, on Microsoft Windows [Versione 10.0.17134.1726], locale it-IT)
    • Flutter version 1.22.1 at D:\Flutter\flutter
    • Framework revision f30b7f4db9 (5 days ago), 2020-10-08 10:06:30 -0700
    • Engine revision 75bef9f6c8
    • Dart version 2.10.1

[√] Android toolchain - develop for Android devices (Android SDK version 30.0.2)
    • Android SDK at C:\Users\2024\AppData\Local\Android\sdk
    • Platform android-30, build-tools 30.0.2
    • Java binary at: D:\Java\jdk1.8.0_191_x64\bin\java
    • Java version Java(TM) SE Runtime Environment (build 1.8.0_191-b12)
    • All Android licenses accepted.

[!] Android Studio (not installed)  <- please ignore it, it's a known problem with latest Android Studio 4.1
    • Android Studio not found; download from https://developer.android.com/studio/index.html
      (or visit https://flutter.dev/docs/get-started/install/windows#android-setup for detailed instructions).

[√] VS Code (version 1.50.0)
    • VS Code at C:\Users\2024\AppData\Local\Programs\Microsoft VS Code
    • Flutter extension version 3.15.0