Sdk: dartanalyzer not generating diagnostics for pubspec.yaml files

[pq]

To reproduce,

1. enable sort_pub_dependencies
2. unsort pub dependecies
3. run analyzer

[~/src/repos/linter] (master) $ dartanalyzer .
Analyzing linter...
No issues found!

(No issues are reported in IntelliJ either.)

The linter binary does pick these up (and explains why our tests haven't noticed the regression):

[~/src/repos/linter] (master) $ dart bin/linter.dart .
/Users/pq/src/repos/linter/pubspec.yaml 16:3 [lint] Sort pub dependencies.
  analyzer: ^0.40.0
  ^^^^^^^^

/fyi @jonasfj

[bwilkerson]

That's working as expected (though not necessarily as intended :-) ). The command-line analyzer only analyzes .dart files unless you explicitly specify a non-.dart file on the command line. I believe that the analysis server (and hence the future dart analyze command) analyzes all of the files in the directory that we know how to analyze.

[pq]

Aha. That's helpful and yeah, a little surprising. I'm not sure it's entirely work there either though?

[~/src/repos/linter] (master) $ dartanalyzer pubspec.yaml 
Analyzing pubspec.yaml...
No issues found!

More importantly, IntelliJ isn't reporting the diagnostic either. I'm not sure if that's an IntelliJ issue or server yet.

[walnutdust]

hi! I'm still pretty new to this codebase so my conclusions may be incorrect, but I had taken a look at this issue a while back, and I think for the command-line analyzer, the reason why it's not analyzing pubspec.yaml properly is because of these lines, which causes the pubspec.yaml file to only be analyzed based on the PubspecValidator in analyzer.

[pq]

Thanks for taking a look @walnutdust!

My attention has been on server, with a proof of concept up for discussion here: https://dart-review.googlesource.com/c/sdk/+/164249

The CLI would need some updating as well.

[devoncarew]

Is this currently just an issue with dartanalyzer (from the command line, but not from IDEs)?

[pq]

It's an issue in IDEs as well.

[bwilkerson]

The command-line dartanalyzer tool doesn't report any diagnostics for YAML files unless they are explicitly listed on the command-line. It might not even do so when they are listed.

The analysis server reports some diagnostics, but wasn't reporting lints for them, even though we have implemented a couple of lints. Phil's CL will fix server so that lints are produced by server.

[pq]

The rub is that _analyzePubspecFile in the context manager is not running lints. I've got this hacked locally and it seems straight-forward -- needs some testing and review though.

[devoncarew]

Ah, ok. I'll rename this to reflect that this is (or will soon be) dartanalyzer specific.

[pq]

As for Brian's comment, even if you specify a pubspec on the CLI lints won't be run.

[pq]

UPDATE: the Flutter Engine roll was blocked on a false positive in the newly reporting sort_pub_dependencies (https://github.com/dart-lang/linter/issues/2271) so I'm rolling this back pending a fix to the lint: https://dart-review.googlesource.com/c/sdk/+/166703.

[pq]

UPDATE: false alarm. Lint was fine after all. Staging change for re-landing. 👍