Sdk: Request for a cherry-pick so that Flutter can hotfix it into stable
Because of App startup crash on android arm device, flutter would like to cherry pick 5581307 onto a4911c6 (which is the revision stable is currently using). Is this possible?
Dart revision flutter stable is currently using: https://github.com/dart-lang/sdk/commit/a4911c63f4f72ba571d6db94de56007b09f4af99
Dart commit with fix: https://github.com/dart-lang/sdk/commit/5581307ae6ade7a6a093a9643993b159f270ac56
christopherfujino
All 5 comments
@athomas
christopherfujino
on 3 Feb 2020
It is possible but I would advise against this. We have zero test coverage for special branches and the stable branch is already beyond a4911c6 (that is source equivalent to Dart stable 2.7.0). The stable branch is at 2.7.1 and the safe option would be cherry-pick 5581307 onto stable and call it 2.7.2 and then hotfix that into Flutter.
athomas
on 3 Feb 2020
Given the risk of picking up further upstream commits, I'm going to close this issue. Thanks!
christopherfujino
on 3 Feb 2020
@christopherfujino @athomas - when is new stable release planned for? Will this fix be on 1.12 or 1.14?
IMO, this is a showstopper for 1.12 version, app crashes on startup on real device and the version is useless with this bug. And we, as a developers, can't do anything about it. It should be pushed to the stable as soon as possible.
samardzija
on 4 Feb 2020
@samardzija you have a valid point. the decision not hotfix was from the flutter team. Could we move this conversation to the flutter issue?
christopherfujino
on 4 Feb 2020
Related issues
xster
路
3Comments
sgrekhov
路
3Comments
bergwerf
路
3Comments
rinick
路
3Comments
DartBot
路
3Comments
Most helpful comment
@christopherfujino @athomas - when is new stable release planned for? Will this fix be on 1.12 or 1.14?
IMO, this is a showstopper for 1.12 version, app crashes on startup on real device and the version is useless with this bug. And we, as a developers, can't do anything about it. It should be pushed to the stable as soon as possible.