Sdk: Browser tests timing out with 2.8.0-dev.1.0
See
https://travis-ci.org/dart-lang/fake_async/jobs/636976975
https://travis-ci.org/dart-lang/clock/jobs/636977006
https://travis-ci.org/dart-lang/sample-pop_pop_win/jobs/637003551
CC @grouma @athomas
Not sure the root cause here...
kevmoo
All 8 comments
I think this was likely fixed by https://github.com/dart-lang/sdk/commit/12984eee89bbd668574124171ea7a66f03d77113 which didn't make it into that dev release.
jakemac53
on 14 Jan 2020
cc @fishythefish
jakemac53
on 14 Jan 2020
An assert would cause a hang in production?
kevmoo
on 14 Jan 2020
My understanding is that the assert would cause a failure in the root of the browser bootstrap logic which could cause a hang.
grouma
on 14 Jan 2020
The assert is actually inside of dart2js library code. If asserts are enabled then this would cause the test to fail to load because it happens during the test communication setup between the runner and browser.
jakemac53
on 14 Jan 2020
@athomas 鈥撀爐his is worth doing a -dev.2.0 or -dev.1.1 roll!
kevmoo
on 14 Jan 2020
I will start 2.8.0-dev.2.0 build based on https://github.com/dart-lang/sdk/commit/d1e11f088108b5ec90fcc2faef7ed1437b018f47 (includes the fix and is the latest that passed the internal roll).
athomas
on 14 Jan 2020
Calling this fixed!
kevmoo
on 15 Jan 2020
Related issues
rinick
路
3Comments
brooth
路
3Comments
Hixie
路
3Comments
nex3
路
3Comments
DartBot
路
3Comments
Most helpful comment
I will start 2.8.0-dev.2.0 build based on https://github.com/dart-lang/sdk/commit/d1e11f088108b5ec90fcc2faef7ed1437b018f47 (includes the fix and is the latest that passed the internal roll).