Sdk: Dartium crashes if Dart app is inside iframe
Description:
Dartium crashes if an application is in an iframe and a debugger breakpoint is placed anywhere in the code of that "iframed" application.
Affected versions
- Version 45.0.2454.0 64 and 32 bit versions
Version 39.0.2171.0 (64-bit) _worked._ (1.13.0 dart version)
Reproduction:
Have these 2 HTML files and dart file:
<!-- index.html -->
<html><body>
<iframe src="dartapp.html"></iframe>
</body></html>
<!-- dartapp.html -->
<html><body>
<script src="dartapp.dart" type="application/dart"></script>
</body></html>
// dartapp.dart
main() {
print("I crash if you put a breakpoint on me");
}
daniel-v
All 20 comments
Are there any plans to fix this?
goderbauer
on 28 Apr 2016
I'll take a look.
terrylucas
on 28 Apr 2016
Thank you. Much appreciated.
goderbauer
on 28 Apr 2016
If we could get a fix for this merged into stable, that would be great. It pretty much totally breaks users' ability to debug their tests using the test package.
nex3
on 28 Apr 2016
@terrylucas Thanks for taking a look.
I too would like to see this in stable, for a good while now, I cannot debug in Dartium.
daniel-v
on 29 Apr 2016
/cc @mit-mit
floitschG
on 29 Apr 2016
@terrylucas we need a fix in the next few days if this is to make it into the planned final 1.17 stable build next week.
mit-mit
on 27 May 2016
CC @whesse
mit-mit
on 27 May 2016
I have been heads down in code yellow I'll take a look today and talk to Jacob about possible solutions.
terrylucas
on 31 May 2016
I've narrowed the problem down to the devToolsAgentClient not being set up properly in frame other than the main frame. Looking at a couple of possible solutions.
The problem has existed since 1.16
terrylucas
on 1 Jun 2016
Meant to say since rolling to Chrome 45.
terrylucas
on 1 Jun 2016
FYI: it looks like this happens in Dart 1.15, too.
Confirmed it does work in Dart 1.14.2.
We should fix this, but it is not blocking for 1.17 鈥撀爄t's been around for 2 releases.
kevmoo
on 1 Jun 2016
Agree, it's not blocking the 1.17.0 release, but we could do a 1.17.1 patch release if needed. @daniel-v, @goderbauer can you elaborate on the need to get a stable patch for this?
mit-mit
on 1 Jun 2016
@mit-mit sure. We consider this a high-impact issue as it slows down our development cycle significantly.
It takes about 7 minutes to compile our Dart application on the dev's machines so that they can debug in Chrome with some source map's available.
So if the question is if we need it: we do, very much so!
@kevmoo you are right, it's been around for 2 releases and I am very hopeful that it won't be in the next one.
Thank you from: Easyling
daniel-v
on 1 Jun 2016
@daniel-v to be 100% clear.
We absolutely consider this critical. We will make all efforts to get a patch out as 1.17.1 or similar.
This is just how we handle bookkeeping for major releases.
1.17 is broken, but no more broken than 1.15.2 wrt this issue.
Thank you much for your patience here.
kevmoo
on 1 Jun 2016
@kevmoo thanks for clearing it up and for the insight into your bookkeeping process.
I am happy with 1.17.1 or similar. :)
daniel-v
on 1 Jun 2016
Have a fix CL sent out a build of Dartium to get banged on to make sure it works for more complex iFrame debugging.
terrylucas
on 1 Jun 2016
Confirmed fixed (in private build) from Michael Goderbauer.
terrylucas
on 1 Jun 2016
Confirmed fixed in Dart VM version: 1.17.0-dev.6.1 - mac.
Thanks, @terrylucas !
kevmoo
on 2 Jun 2016
Resolved in 5a9b600 - master
Resolved in 25b5232 - v1.17 dev branch
kevmoo
on 2 Jun 2016
Related issues
gspencergoog
路
3Comments
DartBot
路
3Comments
nex3
路
3Comments
xster
路
3Comments
matanlurey
路
3Comments
Most helpful comment
If we could get a fix for this merged into stable, that would be great. It pretty much totally breaks users' ability to debug their tests using the test package.