Sdk: dartanalyzer reports the same error multiple times when given multiple entry points

[skybrian]

To reproduce, create three files:

entry1.dart

import "target.dart";

main() {
  print(x);
}

entry2.dart

import "target.dart";

main() {
  print(x);
}

target.dart

var x = 3;

asdf

Then run dartanalyzer on both entry files:

$ dartanalyzer entry1.dart entry2.dart 

It will analyze them sequentially and print the same error twice. If given a lot of files (for example using a glob) then you get lots of duplicates.

[skybrian]

This is also true when using --machine.

[nex3]

Can we increase the priority on this? It's very frustrating when dealing with large packages, especially when they have a couple intended hints (for example, many packages refer to their own deprecated members). Passing dartanalyzer lib/ should be the recommended way of analyzing all the libraries in a package, but it can drown the user in duplicate errors which makes it very painful in practice.

[devoncarew]

This is still on track for 1.23; it's about a day of work. I can get to it; @danrubel has also said that an upcoming refactoring he's considering may also cover this issue.

[dgrove]

@devoncarew any update on this?

[devoncarew]

Still planned. I see that the milestone for 1.23 is targeted to March 29th; is that accurate?

[dgrove]

Thanks! That's the correct day.

On Wed, Mar 15, 2017 at 4:16 PM, Devon Carew [e-mail]
wrote:

Still planned. I see that the milestone for 1.23 is targeted to March
29th; is that accurate?

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/dart-lang/sdk/issues/25697#issuecomment-286909378,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACAsW-Z-GufghhYMmkOacx-3rfO6Hi0Yks5rmHE6gaJpZM4HT8g2
.

[devoncarew]

Annnnnd, bumping to the next milestone.

[devoncarew]

https://codereview.chromium.org/2793813002/

[devoncarew]

fixed in master