Screwdriver: Enable to use HTML <a> tag on a banner

Created on 26 Aug 2019  路  2Comments  路  Source: screwdriver-cd/screwdriver

What happened:
We cannot use <a> tag on a banner. A link on banner should be useful.

What you expected to happen:
We can use <a> tag on a banner.

How to reproduce it:
Create a banner with <a> tag or any HTML tags.

bug ui

Most helpful comment

This issue should be fixed with UI: v1.0.453

Screen Shot 2019-10-16 at 4 45 08 PM

All 2 comments

It doesn't look like we do not allow for <a> tag in the data-schema validation. I checked and it looks like <a> is getting encoded at some point, probably in handlebars.

Can probably just change from double {{ to triple {{{ in this file: https://github.com/screwdriver-cd/ui/blob/master/app/components/nav-banner/template.hbs#L7

Ref: http://www.kaspertidemann.com/html-safe-strings-in-handlebars/

This issue should be fixed with UI: v1.0.453

Screen Shot 2019-10-16 at 4 45 08 PM

Was this page helpful?
0 / 5 - 0 ratings

Related issues

stjohnjohnson picture stjohnjohnson  路  5Comments

catto picture catto  路  6Comments

tk3fftk picture tk3fftk  路  3Comments

tk3fftk picture tk3fftk  路  5Comments

yoshwata picture yoshwata  路  5Comments