Scrcpy: Always on top for Mac OS

[mikescamell]

I really like using scrcpy and was excited to see the always on top feature added. But I believe this is just for Windows or Linux? It doesn't work on Mojave on my Mac at least. It would be great if this could be added.

[rom1v]

Indeed, it seems only implemented for X11 and Windows in SDL (src/video/x11/SDL_x11window.c and src/video/windows/SDL_windowswindow.c).

You should open a bug on LibSDL, since _scrcpy_ just sets the flag.

[mikescamell]

Would the bug be something along the lines of "Allow always on top on Mac OS" like that I've asked here?

[npes87184]

Would the bug be something along the lines of "Allow always on top on Mac OS" like that I've asked here?

Yes, for more detail, you can specify that the flag SDL_WINDOW_ALWAYS_ON_TOP doesn't apply to MacOS.

[gabrielformiga]

In case you still want this you can build sdl from my fork:
https://github.com/gabrielformiga/SDL-mirror/tree/mac_window_always_top

[rom1v]

Did you propose a patch to SDL upstream?

[gabrielformiga]

Not yet, but I'm gonna propose.

[gabrielformiga]

Just in case you want to track this:
https://bugzilla.libsdl.org/show_bug.cgi?id=4809

[rom1v]

Thank you :+1:

[hacker1024]

This has been merged, but always-on-top isn't working for me with 1.11 on Catalina...

https://github.com/spurious/SDL-mirror/commit/1c8dffa9b2fe89e3d15014b1994c21a0bbfca773

[rom1v]

@hacker1024 probably for the next release of SDL?

[hacker1024]

Oh, right

[hacker1024]

I just built 1.11 with the master branch of sdl2 and can confirm that the patch works.

Here's the binary if anyone wants it.

[gabrielformiga]

I think it's gonna be available on 2.0.12. The Bugzilla is marked with target-2.0.12