Scratchaddons: Add color selection settings to Scratch 2.0 -> 3.0
This awesome addon by Maximouse can easily alter the colors of the header and the hover color and normal color of links. Please add this function into settings!
Explosion-Scratch
All 15 comments
I think adding this by 1.1 is appropriate.
Explosion-Scratch
on 5 Oct 2020
Is it OK if this feature is only available when 2.0 → 3.0 is enabled? That way it would be much less work to implement.
mxmou
on 5 Oct 2020
@mxmou Wdym by that? Keep in mind css variables accessing addon settings does not work yet
WorldLanguages
on 5 Oct 2020
Hmm. I didn't know that. It's likely possible to use JS vars and then set the CSS ones to that...
Explosion-Scratch
on 5 Oct 2020
This is blocked by #151.
GrahamSH-LLK
on 6 Oct 2020
@mxmou Wdym by that? Keep in mind css variables accessing addon settings does not work yet
An userscript could set CSS variables.
mxmou
on 6 Oct 2020
@mxmou Sure, but it would be better if no js was needed for that.
WorldLanguages
on 7 Oct 2020
@mxmou Can you confirm the state of this? You can now retrieve colors of type settings from CSS via variables. It's not documented yet, but you can see how other addons do it.
WorldLanguages
on 22 Oct 2020
Did you guys know you can do this:
document.style.setProperty('--variable', whatever);
On Thu, Oct 22, 2020 at 3:20 PM World_Languages notifications@github.com
wrote:
@mxmou https://github.com/mxmou Can you confirm the state of this? You
can now retrieve colors of type settings from CSS via variables. It's not
documented yet, but you can see how other addons do it.—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/ScratchAddons/ScratchAddons/issues/415#issuecomment-714738514,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AOT2P3R7WUYOLEVXM5TO43TSMCH2JANCNFSM4SE6I7FA
.
Explosion-Scratch
on 23 Oct 2020
Nice try @Explosion-Scratch, yes we know and it's not needed here. Also, you forgot "documentElement", that won't work :P
WorldLanguages
on 23 Oct 2020
@WorldLanguages I know that's possible now, I'm going to implement this after I finish my dark mode.
mxmou
on 23 Oct 2020
Nice try @Explosion-Scratch, yes we know and it's not needed here. Also, you forgot "documentElement", that won't work :P
*sigh* Just trying to help. Still learning JS lol
Explosion-Scratch
on 23 Oct 2020
@WorldLanguages I know that's possible now, I'm going to implement this after I finish my dark mode.
@mxmou Anything new?
GrahamSH-LLK
on 10 Nov 2020
@GrahamSH-LLK I just opened the PR for dark mode (#699), so I'm probably going to do this after #700 and #701 are resolved.
mxmou
on 10 Nov 2020
@mxmou Now?
GrahamSH-LLK
on 15 Dec 2020
Related issues
pufferfish101007
·
4Comments
GrahamSH-LLK
·
8Comments
WorldLanguages
·
10Comments
GrahamSH-LLK
·
3Comments
jeffalo
·
4Comments
Most helpful comment
@WorldLanguages I know that's possible now, I'm going to implement this after I finish my dark mode.