Scratch-www: Translate email confirmation banner strings?

Created on 29 Jul 2020  路  4Comments  路  Source: LLK/scratch-www

In the src/views/splash/presentation.jsx file, there are a few strings that are not translated.

  • "Confirm your email" (a link) and "to enable sharing" -- these may be difficult to translate due to the different structures of sentences in different languages. Perhaps make the whole sentence a link?
  • "Having trouble?"
High Impact Medium Severity help wanted localization needs discussion priority 2

Most helpful comment

@benjiwheeler I think I can do this

                    <DropdownBanner
                        className="warning"
                        key="confirmedEmail"
                        onRequestDismiss={() => { // eslint-disable-line react/jsx-no-bind
                            this.props.onDismiss('confirmed_email');
                        }}
                    >
                        <FormattedMessage
                            id="emailbanner.confirmEmail"
                            values={{
                                link: (
                                    <a
                                        href="#"
                                        onClick={this.props.onShowEmailConfirmationModal}
                                    >
                                        <FormattedMessage id="emailbanner.confirmEmailLink" />
                                    </a>
                                )
                            }}
                        />
                        <a href="/info/faq/#accounts">
                            <FormattedMessage id="emailbanner.havingTrouble" />
                        </a>
                    </DropdownBanner>,
    "emailbanner.confirmEmail": "{link} to enable sharing",
    "emailbanner.confirmEmailLink": "Confirm your email",
    "emailbanner.havingTrouble": "Having trouble?"

All 4 comments

I labeled this with relatively high impact/severity because it appears to affect all new non-English users.

@benjiwheeler I think I can do this

                    <DropdownBanner
                        className="warning"
                        key="confirmedEmail"
                        onRequestDismiss={() => { // eslint-disable-line react/jsx-no-bind
                            this.props.onDismiss('confirmed_email');
                        }}
                    >
                        <FormattedMessage
                            id="emailbanner.confirmEmail"
                            values={{
                                link: (
                                    <a
                                        href="#"
                                        onClick={this.props.onShowEmailConfirmationModal}
                                    >
                                        <FormattedMessage id="emailbanner.confirmEmailLink" />
                                    </a>
                                )
                            }}
                        />
                        <a href="/info/faq/#accounts">
                            <FormattedMessage id="emailbanner.havingTrouble" />
                        </a>
                    </DropdownBanner>,
    "emailbanner.confirmEmail": "{link} to enable sharing",
    "emailbanner.confirmEmailLink": "Confirm your email",
    "emailbanner.havingTrouble": "Having trouble?"

@apple502j Thanks! Go for it!

Closing this to avoid intersecting with https://github.com/LLK/scratch-www/issues/4390

Was this page helpful?
0 / 5 - 0 ratings