Scratch-www: Extra space beneath "What's Happening" feed, especially noticeable on iPad + Safari

[jwzimmer]

There is some extra space underneath the last activity in the What's Happening feed, but it is especially noticeable if you are using an iPad (Safari). This exists on both Staging & Production.

To repro, view user's jwzimmer1990 What's Happening activity feed.

Chrome 60, Mac OS El Capitan

Small & Large iPads, Safari

• Small apple tablet, iPad 10.3.1, no. 3 (in cart), Safari
• Large apple tablet, iPad 9.3.5, no. 10 (in cart), "cold pizza", Safari
  
  

[Kenny2github]

This seems to be caused by the height of the Scratch News box - on narrower screens the box is taller and the "What's Happening?" box has the same height as it.

Possible fix would be allow more than five items to be shown in that box...?
EDIT: Repro-ed on Chrome 60 on Windows 10:

[DeleteThisAcount]

I know this may sound a little silly but does anyone know where the code is for the what's happening box?

[kerrtravers]

I know this may sound a little silly but does anyone know where the code is for the what's happening box?

That's what I was wondering. 😆

[TheGrits]

I know this may sound a little silly but does anyone know where the code is for the what's happening box?

That's what I was wondering. 😆

My gut tells me it's in the scratchr2 repository, which isn't accessible to the public.

[kerrtravers]

@TheGrits Ah

[towerofnix]

@TheGrits More likely in scratch-api (also a private repository), since the "what's happening?" box has been migrated to use the new API (api.scratch.mit.edu instead of scratch.mit.edu/site-api).

[chrisgarrity]

Actually the limit is in the getActivity function: https://github.com/LLK/scratch-www/blob/e8671c1727fd5af2e8ee55182cb51b03074f4c24/src/views/splash/splash.jsx#L74

[kerrtravers]

@chrisgarrity Perfect, If we were to change that to six I think the bottom user's profile image would be cut off slightly. If after testing it this does happen, We could make the 6 profile images a bit smaller to fit them all in.

[Sheshank-s]

I don't think we should do that, because 5 is like a common number... Idk how to explain it but i think you understand what im saying. Usually multiples of 5 are used, lol I can't word this properly

[Kenny2github]

I'd say make that number dynamic depending on the actual height of the box... but I don't know how to do that.

[kyleplo]

Unrelated, but why is the nav orange?

[Kenny2github]

@kyleplo that's the header for the "staging" server, a private version of the website that uses the develop branch rather than master.

[kyleplo]

@Kenny2github That's what I thought