Scratch-vm: Any block with branch(es) will loop depending on the last block in the branch

[towerofnix]

Expected Behavior

Block execution behaves as normal.

Actual Behavior

In a block formation such as this, the "play sound" block will loop over on itself:

In this script, the "play drum" block loops:

In this script, no blocks loop – it behaves as you'd expect (play sound, wait 0.25 seconds, end):

In this script, however, the two blocks do loop:

Note that the parent block (i.e., the one with branches) is looping. This script will play a single meow and then constantly run the "play drum" block:

A few other blocks I noticed that caused these issues when put at the end of a branch – "rest for beats", "say"/"think", but not "wait 1 secs". I imagine this is probably an issue in how a block is marked as "finished running"..?

Steps to Reproduce

Create scripts as described in "actual behavior" and run them.

Operating System and Browser

macOS 10.12, Chrome 56

[thisandagain]

Hi @liam4. I believe that this may be a dupe of https://github.com/LLK/scratch-vm/issues/464, but the screenshots and additional tests are most appreciated. I'm going to keep this open for now, but may close should we decide that this is a duplicate.

[griffpatch]

I think this issue is fixed in PR #472

[SillyInventor]

Should be closed?

[towerofnix]

I believe so, yes; the issue isn't happening anymore. Thanks for reminding!