Scoutsuite: cloud trail wildcard detection bug

[regevbr]

The check for wildcard s3 data logging is not working.

The reason is that is searchs for arn:aws:s3::: wheres the configuration only has arn:aws:s3 when wildcard is set

The relevant code:

https://github.com/nccgroup/ScoutSuite/blob/faadf03bc0ecd3a628003901d6961c1fe35d1668/ScoutSuite/providers/aws/resources/cloudtrail/trails.py#L52-L61

[x4v13r64]

Thanks for raising this, will look into it.

[x4v13r64]

@regevbr could you please test https://github.com/nccgroup/ScoutSuite/pull/540 to confirm this is resolved?

[regevbr]

@j4v sure, will keep you posted

[regevbr]

@j4v thanks that fixes the problem!
The issue I'm facing now is that all my s3 buckets have the "Bucket access logging disabled" issue flagged, even though your fix should make them not flag that issue...
What do you think?

[x4v13r64]

@regevbr are you sure this is caused by the bugfix/514 branch? There's nothing relating to S3 in there... Could you compare with develop to confirm that branch is causing the issue?

[regevbr]

@j4v my bad I thought those 2 warnings are related, but they have nothing to do with each other.
I consider this bug fixed via your PR.
Thanks for taking care of it :-)

[x4v13r64]

Closing, fixed in develop.