Scout: Form validation in age and tissue type case form

Created on 20 Jan 2020  路  5Comments  路  Source: Clinical-Genomics/scout

  • [x] Validate age and tissue type form on case page.
  • [x] Fix bug that inactivate case when values are submitted using this form
  • [x] The inactivate case feature also appears on other case level changes, e.g. matchmaker submission

Error message for the first part of the issue:
File "/home/hiseq.clinical/SERVER/apps/scout/git/scout/scout/server/blueprints/cases/views.py", line 446, in update_individual
controllers.update_individuals(store, institute_obj, case_obj, user_obj, ind_id, age, tissue)
File "/home/hiseq.clinical/SERVER/apps/scout/git/scout/scout/server/blueprints/cases/controllers.py", line 451, in update_individuals
subject['age'] = round(float(age), 1)
ValueError: could not convert string to float:

bug

All 5 comments

The inactivate case feature also appears on other case level changes, e.g. matchmaker submission.

This fix becomes urgent!

This is very weird, form validation is already in place for age and tissue type fields and it is very complicated to input an age which is not a number. But if you manage to do it the form submission is blocked correctly with an error message (as it should be). Must be some very old browser from the hospital!

Ahhh the error is in the tissue field, found it!

Ahhh the error is in the tissue field, found it!

It wasnt exactly that, but it should be fixed now

Was this page helpful?
0 / 5 - 0 ratings