Suggested improvements for the STR layout:
Thank you Dr @47KW! We will ponder this: especially 1 we will fix as soon as time allows. The other ones are more pipeline issues, that we could of course polish away in scout, but that I would rather distribute out on the respective pipeline components. We will try to do the latter as part of this issue, bit if you have the momentum you could file an issue with genmod about the ranking, MIP and MIP small references about RFC1 etc and link to those here!
I am not sure how to solve 3 for general family structures? Ideas? Fairly straightforward for singletons or trios, although it would be preferable to have the pipeline solve it, and eg integrate with other variants in the gene etc..
Will contemplate over 3). Some things are easy, others are more rewarding 馃槈
Can you call alleles without referring to the reference and then that would make to alleles show up as two rows?
I'm working on this (the things that are quite easy to fix at least). Question:
remove the chromosome postions from certain repeat-names
Could you provide an example of how the name is now it is now and how you would like to have it instead?
Sorry, let me try to annotate where I am so far:
- [ ] The link to IGV viewer "button" has lost its boundaries, square
We (@northwestwitch?) will fix in scout!
- [ ] sort the calls by gene-name or numerically by Chr. and Position. (put the IGV-button outside?)
- [ ] dont use the term rank since its not really a rank
Add a straightforward ranking through stranger. See Stranger issue: https://github.com/moonso/stranger/issues/14
- [ ] make the list viewed as single row for each repeat with both alleles (genotype)
Complicated. We'll keep thinking!
- [ ] remove the chromosome postions from certain repeat-names
- [ ] add RFC1 馃槈
Both of these are largely solved by updating ExHu and references to the latest version. Presumably ready for MIP8 already?
@dnil if you are already working in this I could pick some other issue
MIP 8 uses:
Let us know if you want to make updates.
Thanks! Updates to refs have been to 3.0.1 for some time now. Will add one for 3.1.2!
@northwestwitch Do go ahead: the button should just be a class issue I would guess. If you have a good suggestion for how to display the different alleles in both singletons and extended families that would be welcome!
@dnil Great! Let me know when the ref for 3.1.2 is ready for downloading and testing.
@henrikstranneheim :+1: It will appear on references as usual!
@northwestwitch One thought is to add in the allele sizes directly adjacent to the ref/normal GT calls. And possibly group multiple calls to the same locus on the same table row, but that may get more messy.
Ok @henrikstranneheim! New refs available as a PR for a test spin on reference-files. The reference files should normally track ExHu versions, so new ones in the v3.1.2 subdirectory. If possible, use Stranger v0.5.5 or later to enable transfer of pathogenic range to VCF and Scout. Ehr, pending a full release package in Stranger I note - me fix!
@dnil or @moonso Could you update pypi for stranger to v0.5.5 so I can make an update to the pipeline?
@henrikstranneheim should be on pypi now
Expansionhunter variant catalog and stranger have been updated in MIP and works on hasta
Ok, so that concludes it on the development side! @47KW I'm afraid you will as usual have to wait a little bit before all the goodies arrive on your side. Validation on the MIP side is ongoing, which will when deployed fix some of your issues for new cases. And we should be releasing a patch or minor release of Scout within a week or so which will at least make STRs prettier for all cases! Thanks a bunch for the input! Keep it up!
Most helpful comment
@henrikstranneheim should be on pypi now