Sarama: Discussion - Metrics in sarama

[varun06]

I have been fighting with go-metrics model of doing stats. There is definitely a gap between go-metrics and prometheus etc. Then I came across https://github.com/rcrowley/go-metrics/pull/242#issuecomment-455613410.

That makes me wonder if we should think about doing stats in sarama in a different way. thoughts?

@bai - Please feel free to add more folks here.

[varun06]

@bai have you looked at https://opencensus.io. May be we should use that in place of go-metrics?

[bai]

I'm just flying from KubeCon right now and the news is that OpenCensus and OpenTracing are merging into OpenTelemetry. I think it makes sense to explore using OpenTelemetry instead of go-metrics, I'll take a look and will follow up here over the next few weeks.

(Although metrics are not part of OpenTelemetry per se.)

[varun06]

Oh man, I hope they keep the api same, otherwise it's gonna be a big headache for us. Yeah, let's look at them as they look great for our use case.

[giautm]

OpenCensus look still stable for our, OpenTelemetry has a long milestone to stable - (12/2019)

[bai]

To be honest, given this is a breaking change and it kind of paves the way for Sarama 2.0, I don't think it's going to take less than a few months to go over, incorporate, and stabilize this list.

[varun06]

Yeah, let do that. Also should we add metrics change to above list?

[giautm]

yep, waiting for Sarama@v2.

[probot-shopify[bot]]

Thank you for taking the time to raise this issue. However, it has not had any activity on it in the past 90 days and will be closed in 30 days if no updates occur.
Please check if the master branch has already resolved the issue since it was raised. If you believe the issue is still valid and you would like input from the maintainers then please comment to ask for it to be reviewed.