Sanic: Use httpx instead of requests-async

[honzajavorek]

Is your feature request related to a problem? Please describe.
I just noticed requests-async is mentioned multiple times throughout the project, but the https://github.com/encode/requests-async is archived and https://github.com/encode/httpx is mentioned as a replacement. Perhaps Sanic should recommend httpx instead then?

Describe the solution you'd like
Sanic should mention and work with httpx instead of requests-async.

[harshanarayana]

@honzajavorek Valid point. Let me get this one sorted out later in the day. Thanks for pointing this one out.

When we started using requests-async it was still under development. Looks like we missed the fact that it got archived.

[honzajavorek]

Let me know if I can help.

[yunstanford]

@honzajavorek PRs are welcome

[harshanarayana]

@honzajavorek @yunstanford
I did a quick scan on the changes done by the httpx to the requests-async API and there seem to be a considerable difference. Especially on the ASGI side of the things.

Seems like it needs a bit more work than I initially expected. @honzajavorek Please feel free to open a PR. I am more than happy to help you on anything you need.

I will see if I can make a quick list of the changes required for this migration and list them out here.

[ahopkins]

Sorry guys... that was partially my lapse since I had stepped away for a little bit die to personal reasons. I'm back on this now.

As mentioned, the requests-async package had been under active development. I'll take a look at the changes required because it is a significant requirement for testing. In particular being able to directly reach into the ASGI module without spinning up a server.

[jaylucas]

Any word on this?

[honzajavorek]

I’m still learning my ways around Sanic. When I’m done with my hobby
project using Sanic I want to take a look at this.

On Thu, 21 Nov 2019 at 02:44, Jay Lucas Mutarevic [e-mail]
wrote:

Any word on this?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/huge-success/sanic/issues/1713?email_source=notifications&email_token=AACFGMNGETVDKWW5USCOWVDQUXRZRA5CNFSM4JINLUO2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEEYDUTQ#issuecomment-556808782,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AACFGMJ362GFPRZ5LQOZCTDQUXRZRANCNFSM4JINLUOQ
.

[ahopkins]

WIP: See #1728

[ahopkins]

@tomchristie made some greatly appreciated improvements to httpx (nice work). Much easier to make it extendable than the previous. I took a first pass to clean up and simplify some of the logic, but there are still some tests that need to be cleaned up.