Sanic: Start Initial Support for Python3.8

Created on 23 Oct 2019 · 8Comments · Source: sanic-org/sanic

Description

Considering Python 3.8.0 has been out for a while we can start adding initial support for the Python 3.8 dependencies in the CI/CD pipelines so that we can get a picture of what might break and if there are any early changes we can do to start supporting newer python versions.

@huge-success/sanic-core-devs I Will open a PR to include the dependencies in travis and tox setup so that we can run the tests across those versions to start with

Source

harshanarayana

👍6

Most helpful comment

@Tronic I saw the uvloop notification earlier today about 3.8 support. I guess time to see if we can bump to the latest version and see if we crash the universe or save it.

harshanarayana on 6 Nov 2019

👍3

All 8 comments

SGTM, I'm wondering if there's a way that we can add a python-nightly to the matrix that doesn't actually block PR merges

seemethere on 23 Oct 2019

👍1

@seemethere I like the idea. But we should probably restrict the nightly builds to the travis part and not for the tox env so that we don't break your test mechanisms.

Btw, uvloop is flaky with python 3.8. Doesn't seem to get installed. There is an open issue that I fond. I think we can alter the uvloop requirements to include python version check and add it only for version < 3.8?

harshanarayana on 23 Oct 2019

Python nightly matrix is being added to the travis yml in: https://github.com/huge-success/sanic/pull/1710

seemethere on 23 Oct 2019

Related issue for uvloop installation failure: https://github.com/MagicStack/uvloop/issues/277

seemethere on 23 Oct 2019

So, depend on uvloop>=0.14 now that it is out and working on 3.8?

Tronic on 6 Nov 2019

@Tronic I saw the uvloop notification earlier today about 3.8 support. I guess time to see if we can bump to the latest version and see if we crash the universe or save it.

harshanarayana on 6 Nov 2019

👍3

Hi, guys!

Will be really appreciated if you release a new version with supporting python 3.8,
archlinux already has python 3.8. in latest upgrades, I think other distributives will be has python 3.8. in their updates soon, so the people start bothering you about new release soon too, I'm the first =)