Sanic: Enforce Date Type for Expires on Set-Cookie

[harshanarayana]

Description

As per the HTTP standard guidelines, the Expires parameter of the Set-Cookie needs to be a date in the format specified by the RFC 7231 as shown in Mozilla Dev Guide

Current encode method in sanic's Cookie class though enforces this standard, it will also allow you to set any item as a valid value via an exception catcher block.

Reference

1. encode method in Cookie class
2. Community Discussion Thread

Expected Behavior

Only a valid datetime object that can be converted into a RFC standard date needs to be taken as a valid item

[chenjr0719]

@harshanarayana What about a string with valid format?

Related test:
https://github.com/huge-success/sanic/blob/cea1547e08230b6ad49eb7777fd8db5335382b7a/tests/test_cookies.py#L159-L181

[harshanarayana]

@chenjr0719 ATM, the only way I can think of to enforce the string date format to be compliant with RCF would be via the strptime method. But is it even required to support the date in string format here? I personally think having just datetime support should be fine. But @huge-success/sanic-core-devs can pitch in and suggest maybe?

[ahopkins]

Seems like an extra check during the request/response cycle for a relatively unimportant edge case.

[LTMenezes]

Is anybody currently working on this? I would like to work on this issue.

[ahopkins]

@LTMenezes The job is yours!🤘