Sanic: Remove unwanted None check for __repr__ in `Request` class

Created on 2 Jan 2019  路  1Comment  路  Source: sanic-org/sanic

Description

The current implementation of the Request class provided by sanic has a __repr__ method that performs an unnecessary None check on method and path and there it is not possible that they can be None. We can remove these condition checks and have a much simpler __repr__ implementation.

Reference

  1. __repr__ implementation
  2. Community Discussion Thread
beginner enhancement help wanted
Source
picture harshanarayana
👍2

Most helpful comment

Just a reminder, don't forget the test.
https://github.com/huge-success/sanic/blob/cea1547e08230b6ad49eb7777fd8db5335382b7a/tests/test_requests.py#L558-L567

picture chenjr0719 on 3 Jan 2019
👍2

>All comments

Just a reminder, don't forget the test.
https://github.com/huge-success/sanic/blob/cea1547e08230b6ad49eb7777fd8db5335382b7a/tests/test_requests.py#L558-L567

chenjr0719 picture chenjr0719 on 3 Jan 2019
👍2
Was this page helpful?
0 / 5 - 0 ratings

Related issues

rainyear picture rainyear  路  3Comments
ZeeRoc picture ZeeRoc  路  3Comments
olalonde picture olalonde  路  3Comments
fiecato picture fiecato  路  3Comments
vlad0337187 picture vlad0337187  路  3Comments